cli: Expose certificate_directory

[mkenigs]

Exposes the corresponding options from containers-image-proxy and
skopeo

Also changes authfile type from String to PathBuf for consistency

Helps #121
Depends containers/containers-image-proxy-rs#22

[mkenigs]

@cgwalters are we going to have defaults/a config file for cert_dir? If so, what? What about authfile?

How do I test this with rpm-ostree? I've patched the build. Or do I just test ostree-ext-cli container image pull inside a cluster?

[mkenigs]

Is this too long for the help text?

[cgwalters]

Hmm. I just tried this out and it looks like structopt eats newlines, but does do auto-wrapping. I just tried e.g.:

diff --git a/lib/src/cli.rs b/lib/src/cli.rs
index e6cbaee..9726fcb 100644
--- a/lib/src/cli.rs
+++ b/lib/src/cli.rs
@@ -162,6 +162,7 @@ enum ContainerImageOpts {
     },
 
     /// Copy a pulled container image from one repo to another.
+    /// Blah blah.  Lorem ipsum foo bar baz. Lorem ipsum foo bar baz. Lorem ipsum foo bar baz. Lorem ipsum foo bar baz.
     Copy {
         /// Path to the source repository
         #[structopt(long)]

And I get:

walters@toolbox /v/s/w/s/g/o/ostree-rs-ext (main)> cargo b; and ./target/debug/ostree-ext-cli container image --help
   Compiling ostree-ext v0.5.1 (/var/srv/walters/src/github/ostreedev/ostree-rs-ext/lib)
   Compiling ostree-ext-cli v0.1.4 (/var/srv/walters/src/github/ostreedev/ostree-rs-ext/cli)
    Finished dev [optimized + debuginfo] target(s) in 6.94s
ostree-ext-cli-container-image 0.5.1
Commands for working with (possibly layered, non-encapsulated) container images

USAGE:
    ostree-ext-cli container image <SUBCOMMAND>

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

SUBCOMMANDS:
    copy      Copy a pulled container image from one repo to another. Blah blah.  Lorem ipsum foo bar baz. Lorem
              ipsum foo bar baz. Lorem ipsum foo bar baz. Lorem ipsum foo bar baz
    deploy    Perform initial deployment for a container image
    help      Prints this message or the help of the given subcommand(s)
    list      List container images
    pull      Pull (or update) a container image
walters@toolbox /v/s/w/s/g/o/ostree-rs-ext (main)> 

Soo...it should be fine if you just add a period . at the end of sentences. Or it could be:

/// Directory with certificates (*.crt, *.cert, *.key) used to connect to registry; equivalent to `skopeo --cert-dir`.

or so?

[mkenigs]

Never added the period but not sure that's important

[cgwalters]

@cgwalters are we going to have defaults/a config file for cert_dir? If so, what? What about authfile?

I think we should. There's some bike-shedding involved for that. My strawman would be supporting files in /etc/ostree. On detail: I think we should support these being symbolic links, so that e.g. for OpenShift/MCO we can just ln -s /var/lib/kubelet/config.json /etc/ostree/container-authfile.json or so.

(Now the kubelet pull secret should really be in /etc; that's openshift/machine-config-operator#1190 (comment) )

[cgwalters]

@lucab there's a crate for systemd-style config right? I vaguely recall something in coreos using it; tried looking in afterburn but didn't see it.

[cgwalters]

How do I test this with rpm-ostree? I've patched the build. Or do I just test ostree-ext-cli container image pull inside a cluster?

Yep, the latter should work fine! One trick here I've used is oc cp to copy binaries built from my local workstation to a remote cluster.

[cgwalters]

OK so to make the CI here green, we need to change our Cargo.toml to pull from git. This is another variant of https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

Do you want to do that or OK if I just push the fixups for this?

[cgwalters]

@mkenigs I put together https://gist.github.com/cgwalters/ce13e9d936ea2dd55ad9f159c2e99f68

[mkenigs]

@lucab there's a crate for systemd-style config right? I vaguely recall something in coreos using it; tried looking in afterburn but didn't see it.

@lucab did you ever see that?