Skip to content

Commit

Permalink
Merge pull request #3075 from cgwalters/reenable-composefs
Browse files Browse the repository at this point in the history
tests: Use ext4, re-enable composefs test
  • Loading branch information
cgwalters authored Oct 16, 2023
2 parents 5d92407 + 833251c commit d788c5b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
2 changes: 2 additions & 0 deletions ci/prow/fcos-e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ cd $(mktemp -d)
cosa init https://github.com/coreos/fedora-coreos-config/
rsync -rlv /cosa/component-install/ overrides/rootfs/
cosa fetch
# For composefs
echo 'rootfs: "ext4verity"' >> src/config/image.yaml
cosa build
# For now, Prow just runs the composefs tests, since Jenkins covers the others
#cosa kola run 'ext.ostree.destructive-rs.composefs*'
16 changes: 11 additions & 5 deletions tests/inst/src/composefs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,21 @@ fn verify_composefs_signed(sh: &xshell::Shell, metadata: &glib::VariantDict) ->
Ok(())
}

#[allow(dead_code)]
pub(crate) fn itest_composefs() -> Result<()> {
let sh = &xshell::Shell::new()?;
if !cmd!(sh, "ostree --version").read()?.contains("- composefs") {
println!("SKIP no composefs support");
return Ok(());
}
let mark = match crate::test::get_reboot_mark()? {
None => {
if !cmd!(sh, "ostree --version").read()?.contains("- composefs") {
println!("SKIP no composefs support");
return Ok(());
}
{
let fstype = cmd!(sh, "stat -f / -c %T").read()?;
if fstype.trim() == "xfs" {
println!("SKIP no xfs fsverity yet");
return Ok(());
}
}
cmd!(
sh,
"ostree --repo=/ostree/repo config set ex-integrity.composefs true"
Expand Down
2 changes: 1 addition & 1 deletion tests/inst/src/insttestmain.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const TESTS: &[StaticTest] = &[
];
const DESTRUCTIVE_TESTS: &[StaticTest] = &[
test!(destructive::itest_transactionality),
// test!(composefs::itest_composefs),
test!(composefs::itest_composefs),
];

#[derive(Debug, StructOpt)]
Expand Down

0 comments on commit d788c5b

Please sign in to comment.