[WIP] lib/deploy: Check space before copying into /boot #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check free space on the filesystem before copying the kernel executable, initramfs, and devicetree into the boot partition. Both the get_kernel_from_tree_usrlib_modules() and get_kernel_from_tree_legacy_layouts() code paths query the size of the kernel, initramfs, and devicetree. If hardlinking fails, then sum up what still needs to be copied, and fail if it is greater than the disk space available. Fixes: ostreedev#1648
|
@rfairley: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rfairley: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I'd forgotten about this one, sorry...this fix was done in #2847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this up as a draft, WIP for #1648 .
To finish:
_ostree_deployment_set_bootsizesomewhere beforeinstall_deploy_kernelso that the assertion https://github.com/ostreedev/ostree/compare/master...rfairley:rfairley-filesystem-space-checks-pr?expand=1#diff-f0c889fb056dc4a713f8a87702fdd27eR1687 can succeed.Can be tested by (do this in a virtual machine which is OK to break):