Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/sysroot: Add comments and debug statements around sysroot parsing #2287

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Mar 2, 2021

Was looking at this code more closely today to investigate issues
related to bootlink mismatches (#2283).

@openshift-ci-robot openshift-ci-robot requested review from d4s and lucab March 2, 2021 20:27
@jlebon jlebon force-pushed the pr/deployment-parsing-comments branch from 0ede91f to 3f0944a Compare March 2, 2021 20:27
@jlebon jlebon changed the title lib/sysroot: Add comments and debug statements around parsing lib/sysroot: Add comments and debug statements around sysroot parsing Mar 2, 2021
Was looking at this code more closely today to investigate issues
related to bootlink mismatches (ostreedev#2283).
@jlebon jlebon force-pushed the pr/deployment-parsing-comments branch from 3f0944a to 02b6197 Compare March 2, 2021 20:36
Copy link
Member

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, lucab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon jlebon closed this Mar 3, 2021
@jlebon jlebon reopened this Mar 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit ba40775 into ostreedev:master Mar 3, 2021
@jlebon jlebon deleted the pr/deployment-parsing-comments branch April 24, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants