Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add an integration test for composefs signatures #3021

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

cgwalters
Copy link
Member

Ensure we have some automated test coverage for this.

@cgwalters cgwalters requested a review from alexlarsson August 29, 2023 22:01
@cgwalters cgwalters marked this pull request as draft August 30, 2023 12:30
@cgwalters
Copy link
Member Author

cgwalters commented Aug 30, 2023

OK this doesn't fail but it doesn't quite work either; to do this sanely we want the new rpm-ostree, and I discovered we hadn't built it in Fedora yet; doing that now.

@cgwalters cgwalters force-pushed the insttest-composefs-binding branch from 4250c33 to 439ac37 Compare August 30, 2023 13:11
@cgwalters cgwalters added area/composefs Issues related to composefs area/tests Changes to the tests (or CI flow) labels Aug 31, 2023
@cgwalters cgwalters force-pushed the insttest-composefs-binding branch from 439ac37 to 96162c2 Compare September 20, 2023 23:56
Ensure we have some automated test coverage for this.
@cgwalters cgwalters force-pushed the insttest-composefs-binding branch from 96162c2 to 372cbd7 Compare September 21, 2023 11:53
@alexlarsson
Copy link
Member

I can't say I know these integration tests, and how this works. But from a glance, this looks ok to me.

@cgwalters cgwalters marked this pull request as ready for review September 21, 2023 16:53
@cgwalters cgwalters enabled auto-merge September 21, 2023 16:54
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit 13be078 into ostreedev:main Sep 21, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/composefs Issues related to composefs area/tests Changes to the tests (or CI flow)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants