Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add section about ostree and bootloaders #3116

Merged
merged 1 commit into from
Dec 14, 2023
Merged

doc: Add section about ostree and bootloaders #3116

merged 1 commit into from
Dec 14, 2023

Conversation

jmarrero
Copy link
Member

@jmarrero jmarrero commented Dec 8, 2023

No description provided.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jmarrero jmarrero marked this pull request as ready for review December 13, 2023 17:13
ericcurtin
ericcurtin approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@ericcurtin ericcurtin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I might expand this to speak about Androidy Bootloaders found in ARM Automotive platforms

ericcurtin
ericcurtin reviewed Dec 14, 2023
View reviewed changes
docs/bootloaders.md Outdated

## GRUB and os-prober

A specific component of GRUB that can significantly impede the reliabilty of OS updates is the `os-prober` aspect, which scans all system block devices. If one doesn't care about dual booting, avoiding this is a good idea.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/reliabilty/reliability/g

ericcurtin
ericcurtin reviewed Dec 14, 2023
View reviewed changes
docs/bootloaders.md Outdated

## Anaconda

Until very recently the Anaconda project only supported setting up the bootloader (e.g. GRUB) on its own, which requires `grub2-mkconfig` etc. As of recently, Anaconda now [supports bootupd](https://github.com/rhinstaller/anaconda/pull/5298).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Until very recently the Anaconda/Until very recently, the Anaconda/g

ericcurtin
ericcurtin reviewed Dec 14, 2023
View reviewed changes
docs/bootloaders.md Outdated

## bootupd

As of recently [the bootupd project](https://github.com/coreos/bootupd/) ships [static grub configs](https://github.com/coreos/bootupd/tree/main/src/grub2) and in this case, the `sysroot.bootloader` should be set to `none` (except on s390x).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/As of recently/As of recently,/g

@ericcurtin
Copy link
Collaborator

I found some super minor things, but happy to merge this as is, just say the word

@jmarrero
Copy link
Member Author

I found some super minor things, but happy to merge this as is, just say the word

thanks! and yes please expand this is a needed for auto.

@jmarrero jmarrero enabled auto-merge December 14, 2023 15:50
@ericcurtin ericcurtin disabled auto-merge December 14, 2023 21:52
@ericcurtin ericcurtin enabled auto-merge December 14, 2023 21:53
@ericcurtin ericcurtin disabled auto-merge December 14, 2023 21:53
@ericcurtin ericcurtin enabled auto-merge December 14, 2023 21:53
@ericcurtin
Copy link
Collaborator

/test all

@ericcurtin
Copy link
Collaborator

I only have merge if everything is green permissions, trying to get this build:

ci/prow/fcos-e2e

from orange to green, it seems stuck or something.

@cgwalters
Copy link
Member

It doesn't run for docs-only PRs
/override ci/prow/fcos-e2e

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 14, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/fcos-e2e

In response to this:

It doesn't run for docs-only PRs
/override ci/prow/fcos-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericcurtin ericcurtin merged commit 5c7f42b into ostreedev:main Dec 14, 2023
24 checks passed
@cgwalters cgwalters mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcurtin ericcurtin ericcurtin approved these changes

@cgwalters cgwalters cgwalters left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmarrero @ericcurtin @cgwalters