Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.8-3 coverity minor fixes #3263

Closed
wants to merge 10 commits into from
Closed

2023.8-3 coverity minor fixes #3263

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a8c3c3d
checksum: Null terminate buffer
lukewarmtemp Jun 12, 2024
20a333c
tree: autofree `name` var
lukewarmtemp Jun 12, 2024
f120b7b
commit: Null terminate `target_buf` var
lukewarmtemp Jun 12, 2024
d049c1f
repo: Return copy of local var `ret`
lukewarmtemp Jun 12, 2024
22b77f1
repo: Free actual pointer instead of stolen pointer
lukewarmtemp Jun 12, 2024
383f908
repo: Autofree `ret_rollsum`
lukewarmtemp Jun 12, 2024
b42ef62
repo: Autofree `dir_or_file_path`
lukewarmtemp Jun 12, 2024
81125ff
repo: Autofree contents of `input_mfile`
lukewarmtemp Jun 12, 2024
377dc62
sysroot: Autofree `devpath`
lukewarmtemp Jun 12, 2024
4b0fec2
prepare: Change mount `etc` to absolute path
lukewarmtemp Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/libostree/ostree-repo-static-delta-processing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,10 +423,11 @@ dispatch_bspatch (OstreeRepo *repo, StaticDeltaExecutionState *state, GCancellab
struct bspatch_stream stream;
stream.read = bspatch_read;
stream.opaque = &opaque;
if (bspatch ((const guint8 *)g_mapped_file_get_contents (input_mfile),
g_mapped_file_get_length (input_mfile), buf, state->content_size, &stream)
g_autofree const guint8 *old = (const guint8 *)g_mapped_file_get_contents (input_mfile);
if (bspatch (old, g_mapped_file_get_length (input_mfile), buf,
state->content_size, &stream)
< 0)
return glnx_throw (error, "bsdiff patch failed");
return glnx_throw (error, "bsdiff patch failed");
lukewarmtemp marked this conversation as resolved.
Show resolved Hide resolved

if (!_ostree_repo_bare_content_write (repo, &state->content_out, buf, state->content_size,
cancellable, error))
Expand Down