Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename external traffic flags #123

Merged
merged 20 commits into from
Nov 12, 2023

Conversation

NetanelBollag
Copy link
Contributor

Deprecate the flags autoCreateNetworkPoliciesForExternalTraffic and autoCreateNetworkPoliciesForExternalTrafficDisableIntentsRequirement and replace them with the flag allowExternalTraffic who receives the options ifBlockedByOtterize, off or always.

Comparing the old flags to the allowExternalTraffic

allowExternalTraffic autoCreateNetworkPoliciesForExternalTraffic autoCreateNetworkPoliciesForExternalTrafficDisableIntentsRequirement
ifBlockedByOtterize true false
off false false
always true true

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Checklist

  • I have added documentation for new/changed functionality in this PR and in github.com/otterize/docs

@NetanelBollag NetanelBollag force-pushed the netanelb/rename-allow-external-policy-flags branch 2 times, most recently from 09d6a22 to a255b37 Compare October 4, 2023 10:05
@orishoshan
Copy link
Contributor

@NetanelBollag Since this is a breaking change, remember to update the chartVersion.

@NetanelBollag
Copy link
Contributor Author

NetanelBollag commented Oct 5, 2023

@orishoshan you can review this, the E2E test will fail until we will merge the operator PR

@NetanelBollag NetanelBollag force-pushed the netanelb/rename-allow-external-policy-flags branch from a4811a7 to c353563 Compare October 16, 2023 17:26
@NetanelBollag NetanelBollag requested review from orishoshan and removed request for evyatarmeged October 16, 2023 18:42
@NetanelBollag NetanelBollag force-pushed the netanelb/rename-allow-external-policy-flags branch from dacc9aa to e53fc85 Compare November 12, 2023 14:23
@NetanelBollag NetanelBollag merged commit 1ca507c into main Nov 12, 2023
2 checks passed
@NetanelBollag NetanelBollag deleted the netanelb/rename-allow-external-policy-flags branch November 12, 2023 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants