-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename external traffic flags #123
Merged
NetanelBollag
merged 20 commits into
main
from
netanelb/rename-allow-external-policy-flags
Nov 12, 2023
Merged
Rename external traffic flags #123
NetanelBollag
merged 20 commits into
main
from
netanelb/rename-allow-external-policy-flags
Nov 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetanelBollag
force-pushed
the
netanelb/rename-allow-external-policy-flags
branch
2 times, most recently
from
October 4, 2023 10:05
09d6a22
to
a255b37
Compare
@NetanelBollag Since this is a breaking change, remember to update the chartVersion. |
@orishoshan you can review this, the E2E test will fail until we will merge the operator PR |
NetanelBollag
force-pushed
the
netanelb/rename-allow-external-policy-flags
branch
from
October 16, 2023 17:26
a4811a7
to
c353563
Compare
NetanelBollag
requested review from
orishoshan
and removed request for
evyatarmeged
October 16, 2023 18:42
…is/update-intents-apiversion
… into omris/update-intents-apiversion
…terize/helm-charts into omris/update-intents-apiversion
orishoshan
approved these changes
Oct 22, 2023
…/rename-allow-external-policy-flags
…rename-allow-external-policy-flags
NetanelBollag
force-pushed
the
netanelb/rename-allow-external-policy-flags
branch
from
November 12, 2023 14:23
dacc9aa
to
e53fc85
Compare
NetanelBollag
deleted the
netanelb/rename-allow-external-policy-flags
branch
November 12, 2023 16:07
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the flags
autoCreateNetworkPoliciesForExternalTraffic
andautoCreateNetworkPoliciesForExternalTrafficDisableIntentsRequirement
and replace them with the flagallowExternalTraffic
who receives the optionsifBlockedByOtterize
,off
oralways
.Comparing the old flags to the
allowExternalTraffic
ifBlockedByOtterize
true
false
off
false
false
always
true
true
References
Include any links supporting this change such as a:
If there are no references, simply delete this section.
Checklist