Add support for Linkerd enforcement through ClientIntents #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package contains an engine that creates, updates, deletes linkerd resources from ClientIntents. With a test suite for that feature based on mock. The package will create a Server, AuthPolicy and MTLSAuth for a non HTTP Intent, or a Server ,HTTPRoute , AuthPolicy and MTLSAuth for a HTTP Intent. As well as a NetAuth for probe routes to not cause probes to break from the creation of servers on them. Signed-off-by: aerosouund <[email protected]>
Create Linkerd mock to be used in testing Signed-off-by: aerosouund <[email protected]>
Leverage the linkerd engine in a reconciler that watches ClientIntents Signed-off-by: aerosouund <[email protected]>
Register the linkerd reconciler with the intents reconciler Signed-off-by: aerosouund <[email protected]>
Define constants used by the linkerd manager Signed-off-by: aerosouund <[email protected]>
Signed-off-by: aerosouund <[email protected]>
This is needed as pod ports are required for Linkerd Server creation and they might change if the pod definition changes. Signed-off-by: aerosouund <[email protected]>
…n pod reconciler Signed-off-by: aerosouund <[email protected]>
Signed-off-by: aerosouund <[email protected]>
…to_operator_latest
evyatarmeged
commented
Nov 3, 2024
…t of effective policy)
…nto evya/linkerd_to_operator_latest
omris94
approved these changes
Nov 5, 2024
| for _, ep := range eps { | ||
| result, err := r.applyLinkerdServiceEffectivePolicy(ctx, ep) | ||
| if err != nil { | ||
| r.handleApplyErrors(err, errorList) |
There was a problem hiding this comment.
Suggested change
| r.handleApplyErrors(err, errorList) | |
| errorList = r.handleApplyErrors(err, errorList) |
|
Cool, thank you for working on this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated latest intents operator code with Linkerd support.
References
Code is based off of @aerosouund's PR: #324
Testing
Still need to refactor tests to match new code.
Checklist