Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features #231

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

New features #231

wants to merge 20 commits into from

Conversation

TennyKs
Copy link

@TennyKs TennyKs commented Dec 8, 2020

Add new feature :

  • When two imposters or more are in the same vent, they can speak to each other and no one can hear them.

Add new settings to the game, disabled by default :

  • Allows haunt : Dead players can speak to players who are still alive.
  • Global vents comms : When two imposters or more are in a vent (doesn't matter which one) they can speak to each other and no one can hear them.
  • Hearing Distance : Modify the Hearing distance in-game. If modified, crewlink must be reloaded. The distance is between 0 and 255.

Pull_request

@ottomated
Copy link
Owner

All of these must be controlled by the lobby host and synced across clients. I can't merge this PR until that's implemented.

@TennyKs
Copy link
Author

TennyKs commented Dec 8, 2020

All of these must be controlled by the lobby host and synced across clients. I can't merge this PR until that's implemented.

Okay, and is this already implemented for some settings ? So we can use the same model.

@Bartschey
Copy link

Make Crewlink able to be pinned to the top of all programs so it stays on top.

@Tothas
Copy link

Tothas commented Dec 8, 2020

All of these must be controlled by the lobby host and synced across clients. I can't merge this PR until that's implemented.

Okay, and is this already implemented for some settings ? So we can use the same model.

I think PR #235 would be a good model

@Ornamus
Copy link
Contributor

Ornamus commented Dec 8, 2020

I see a couple spots in Settings where classes are named EaringInputProps and EaringInput, I'd fix those typos.

Do we want an option for haunting ALL living people? I feel like letting ghosts talk to living crewmates would almost always be broken and spoil the game immediately, as the impostor's identities can be given away almost instantly. I think I prefer only letting ghosts talk to living impostors, like the original idea (#25) and my open PR (#192) do it.

The rest of the changes look great though, thanks for doing these! 👍

@TennyKs
Copy link
Author

TennyKs commented Dec 8, 2020

@Ornamus
Oh yeah I forgot these typos, my bad.
For the haunting option, I play with friends, and we find it very fun to still be able to talk to ghosts even when we can't see them. Of course, it's based on fair-play and nothing stop them to reveal the imposter's identity. But they can scare alive players and have small talks without ruining the game.
So yeah, it's only for friends when you trust them to not say everything. This is what it's an option.
And why not both ?

@Tothas
The PR #235 is great, and as soon it's merged i with adapt this PR to use the servers settings.

@Ornamus
Copy link
Contributor

Ornamus commented Dec 8, 2020

@TennyKs
Fair point, I suppose since CrewLink is mainly used among friends that we can just rely on those groups to not abuse it amongst themselves! I support having options for both global haunting and impostor-only haunting then :)

@TennyKs
Copy link
Author

TennyKs commented Dec 8, 2020

@Ornamus
Perfect :)
I'll wait the server settings then.

@notexplosive
Copy link

notexplosive commented Dec 18, 2020

@Ornamus

I suppose since CrewLink is mainly used among friends...

I'm not sure this is true. I mainly use CrewLink in public discords with randoms. I wouldn't trust them not to abuse a feature like this. But it sounds like the consensus is to make this server-settings driven by the host, which assuages my concerns.

Just something to consider.

@KadenBiel
Copy link

@Ornamus

I suppose since CrewLink is mainly used among friends...

I'm not sure this is true. I mainly use CrewLink in public discords with randoms. I wouldn't trust them not to abuse a feature like this. But it sounds like the consensus is to make this server-settings driven by the host, which assuages my concerns.

Just something to consider.

I mean, it's just as easy to unmute yourself on discord and call out the imposters. An option for hosts to enable haunting for just imposters or for everyone or not at all would eliminate this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants