-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hw1 #1166
base: AGaliy/main
Are you sure you want to change the base?
hw1 #1166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно добавить .env.example со всеми возможными переменными окружения.
hw1/code/index.php
Outdated
@@ -0,0 +1,39 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Поправьте все замечания линтера.
hw1/memcached/.Dockerfile
Outdated
@@ -0,0 +1,2 @@ | |||
FROM memcached:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно просто взять базовый образ.
hw1/mysql/Dockerfile
Outdated
@@ -0,0 +1,12 @@ | |||
FROM mysql:8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно просто взять базовый образ.
hw1/redis/Dockerfile
Outdated
@@ -0,0 +1 @@ | |||
FROM redis:alpine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно просто взять базовый образ.
.env
Outdated
@@ -0,0 +1,5 @@ | |||
MYSQL_USER=user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Файл .env должен быть удалён и добавлен в .gitignore
redis/Dockerfile
Outdated
@@ -0,0 +1 @@ | |||
FROM redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Данный образ можно удалить и использовать базовый
mysql/Dockerfile
Outdated
@@ -0,0 +1,12 @@ | |||
FROM mysql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Образ надо удалить и использовать базовый.
memcached/.Dockerfile
Outdated
@@ -0,0 +1,2 @@ | |||
FROM memcached |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Образ надо удалить и использовать базовый.
memcached/.Dockerfile
Outdated
@@ -0,0 +1 @@ | |||
CMD ["memcached", "-D"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Удалите данный файл.
mysql/Dockerfile
Outdated
@@ -0,0 +1,10 @@ | |||
# Set an insecure password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Удалите данный файл.
No description provided.