Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw1 #1166

Open
wants to merge 9 commits into
base: AGaliy/main
Choose a base branch
from
Open

hw1 #1166

wants to merge 9 commits into from

Conversation

alexgaliy
Copy link

No description provided.

Copy link

@dshemin dshemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно добавить .env.example со всеми возможными переменными окружения.

@@ -0,0 +1,39 @@
<?php
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправьте все замечания линтера.

@@ -0,0 +1,2 @@
FROM memcached:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно просто взять базовый образ.

@@ -0,0 +1,12 @@
FROM mysql:8.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно просто взять базовый образ.

@@ -0,0 +1 @@
FROM redis:alpine
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно просто взять базовый образ.

.env Outdated
@@ -0,0 +1,5 @@
MYSQL_USER=user
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Файл .env должен быть удалён и добавлен в .gitignore

redis/Dockerfile Outdated
@@ -0,0 +1 @@
FROM redis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Данный образ можно удалить и использовать базовый

mysql/Dockerfile Outdated
@@ -0,0 +1,12 @@
FROM mysql
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Образ надо удалить и использовать базовый.

@@ -0,0 +1,2 @@
FROM memcached
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Образ надо удалить и использовать базовый.

@@ -0,0 +1 @@
CMD ["memcached", "-D"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Удалите данный файл.

mysql/Dockerfile Outdated
@@ -0,0 +1,10 @@
# Set an insecure password
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Удалите данный файл.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants