Skip to content

Commit

Permalink
refactor(ci): fix build failure (#98)
Browse files Browse the repository at this point in the history
Checks were added to prevent folks from breaking their system's
Python installation by updating it or adding libraries to it.

Our Dockerfile was doing this. So now we don't. We still make
sure that Python 3 is installed. But we don't try to upgrade it
or pip.

In the future, we may want to figure out how to use something
like venv to install a particular version of Python that PLCC will
use, that is independent of the system's Python.

Closes #97
  • Loading branch information
StoneyJackson authored Jan 26, 2024
1 parent b8e2341 commit 457a505
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions containers/plcc/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,7 @@
FROM alpine:3

# Install Python 3
RUN apk add --no-cache python3~=3 \
&& python3 -m ensurepip \
&& pip3 install --upgrade pip setuptools \
&& rm -r /usr/lib/python*/ensurepip \
&& if [ ! -e /usr/bin/pip ]; then ln -s pip3 /usr/bin/pip ; fi \
&& if [[ ! -e /usr/bin/python ]]; then ln -sf /usr/bin/python3 /usr/bin/python; fi \
&& rm -r /root/.cache
RUN apk add --no-cache python3~=3

# Install JDK
RUN apk add --no-cache openjdk17-jdk~=17
Expand Down

0 comments on commit 457a505

Please sign in to comment.