Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report version number from git tag #134

Merged
merged 6 commits into from
May 25, 2024
Merged

fix: report version number from git tag #134

merged 6 commits into from
May 25, 2024

Conversation

StoneyJackson
Copy link
Member

@StoneyJackson StoneyJackson commented May 24, 2024 •
edited
Loading

  • main.py was looking in the wrong directory for .git/ . No more.
  • The version test allowed "unknown". No more.
  • CI was not cloning the complete history, so it did not have all the version tags, so version test failed in CI. No more.

@StoneyJackson
Copy link
Member Author

I'll finish this later.

@StoneyJackson StoneyJackson marked this pull request as ready for review May 25, 2024 02:02
@StoneyJackson StoneyJackson merged commit c6b75f0 into main May 25, 2024
4 checks passed
@StoneyJackson StoneyJackson deleted the fix-version branch May 25, 2024 02:11
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 8.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StoneyJackson