migrate markets from nftobject #155
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@market/components/NFTAsks.tsx
Outdated
| tokenId: string | ||
| contractAddress: string | ||
| collectionName: string | ||
| markets: ReturnType<typeof useToken>['markets'] |
There was a problem hiding this comment.
does typegen generate any types that are a little more intuitive than this?
There was a problem hiding this comment.
My attempt to extract it was unsuccesful. Good thing is that this type is so ugly that it begs for further improvement.
@market/hooks/useAskHelper.ts
Outdated
| // } | ||
| // } | ||
|
|
||
| export const useAskHelper = ({ ask }: ReturnType<typeof useToken>['markets'][0]) => { |
There was a problem hiding this comment.
Same here, think we need more concrete types
@market/hooks/useAskHelper.ts
Outdated
| ) | ||
| const rawAskAmount = useMemo(() => ask?.price?.nativePrice.raw, [ask]) | ||
| const displayAskAmount = useMemo(() => ask?.price?.nativePrice.value, [ask]) | ||
| const usdAskAmount = ask?.price.usdPrice |
There was a problem hiding this comment.
Looks like the formatting has been stripped out here. Are we sure output would be correct?
| }, | ||
| // not timestamp in db, only block number |
There was a problem hiding this comment.
How would we deal with this?
| const auctions = markets.filter( | ||
| (item) => item?.properties?.__typename === 'V3ReserveAuction' | ||
| ) | ||
| const asks = markets.filter((item) => item?.properties?.__typename === 'V3Ask') |
There was a problem hiding this comment.
@olegakbarov here, I think we still need to sort with getLatestBlockNumber. This was a fix for a bug that was causing issues during the summer, at least for Asks
There was a problem hiding this comment.
Thanks for head's up! I assumed sorting from api is sufficient.
@market/hooks/useRelevantMarket.ts
Outdated
| (item) => item?.properties?.__typename === 'V3ReserveAuction' | ||
| ) | ||
| const asks = markets.filter((item) => item?.properties?.__typename === 'V3Ask') | ||
| const offers = markets.filter((item) => item?.properties?.__typename === 'V1Offer') | ||
|
|
||
| const ask = asks[0] | ||
| const auction = auctions[0] | ||
| const offer = offers[0] |
There was a problem hiding this comment.
We should return all offers and not just offers[0]... all offers are relevant (this is changed in the PR I pushed yesterday... we'd need to merge from main or fix it here)
compositions/NFTPage/NFTMarket.tsx
Outdated
|
|
||
| if (nftObj) { | ||
| if (hasActiveAuction) { |
There was a problem hiding this comment.
Please make sure all the logic from main is reconciled in the sidebar!
| setTimeout(() => revalidate({ retryCount }), 5000) | ||
| }, | ||
| dedupingInterval: 10000, | ||
| refreshInterval: 5000, |
There was a problem hiding this comment.
Can probably reduce this frequency
olegakbarov
changed the title
NFTObjectwill dramatically simplify codebase and remove dependency onzdk.tokenandmarketstokenId,contractAddressare currently "drilled" through number of components, but it makes sense to extract them in provider later on.useAskHelperanduseRelevantAskessentially unlocks the migration toNFTObjectas those are two main touch points where legacy data types are used