Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transfer hook extension into erc721a to match 1155 #172

Merged
merged 2 commits into from
May 29, 2024

Conversation

iainnash
Copy link
Collaborator

@iainnash iainnash commented Mar 12, 2024

This allows creators to add custom NFT metadata, marketplace, and user interaction hooks to ZORA NFT contracts.

It also adds feature parity to our 1155 contracts.


Generated summary (powered by Graphite)

TL;DR

This pull request includes changes to the ERC721Drop.sol file, importing new interfaces and storage contracts related to transfer hooks. It also updates functions for minting tokens, handling rewards, setting transfer hooks, and more.

What changed

  • Imported storage contracts for ERC721Drop, including ERC721DropStorageV2 and ERC721TransferHookStorageV1
  • Added functions for handling rewards, setting transfer hooks, and minting tokens
  • Updated functions for purchasing tokens, setting metadata renderers, and withdrawing funds
  • Introduced new interfaces and storage contracts for transfer hooks

How to test

  1. Review the changes made to the ERC721Drop.sol file
  2. Test functions for minting tokens, handling rewards, and setting transfer hooks
  3. Verify the functionality for purchasing tokens, setting metadata renderers, and withdrawing funds
  4. Check the implementation of new interfaces and storage contracts for transfer hooks

Why make this change

  • To improve the efficiency and functionality of the ERC721Drop contract
  • To enhance the minting, rewards handling, and transfer hook setting processes
  • To ensure compatibility with new interfaces and storage contracts for transfer hooks

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iainnash and the rest of your teammates on Graphite Graphite

@iainnash iainnash marked this pull request as ready for review March 14, 2024 16:25
@iainnash iainnash changed the title Add transfer hook extension back into erc721a Add transfer hook extension into erc721a to match 1155 Mar 14, 2024
@fascinated
Copy link

😍😍😍

Copy link
Contributor

@kulkarohan kulkarohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC721Drop | 0.01 KB left

valid change by a hair lol

@iainnash iainnash merged commit 62f14b9 into main May 29, 2024
4 checks passed
@iainnash iainnash deleted the 03-11-Add_transfer_hook_extension_back_into_erc721a branch May 29, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants