Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typos corrected in comments and variables #472

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix: Typos corrected in comments and variables #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4ab4f8
fix:typo IERC20Z.sol
qvkare Dec 9, 2024
ef3b973
update SponsoredSparksSpender.sol
qvkare Dec 9, 2024
36c2726
correct typo ZoraTimedSaleStrategyMarketTest.t.sol
qvkare Dec 9, 2024
414c281
sparkValue description typedData.ts
qvkare Dec 9, 2024
fbdd72c
fix: typo premint-client.ts
qvkare Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/erc20z/src/interfaces/IERC20Z.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ interface IERC20Z is IERC20Metadata {
/// @notice Error when trying to swap ERC1155 to ERC20Z without the market being started.
error SecondaryMarketHasNotYetStarted();

/// @notice Only supports recieving ERC1155 associated with ERC20Z NFTs.
/// @notice Only supports receiving ERC1155 associated with ERC20Z NFTs.
error OnlySupportReceivingERC1155AssociatedZoraNFT();

/// @notice Unauthorized to call this function
Expand Down
2 changes: 1 addition & 1 deletion packages/erc20z/test/ZoraTimedSaleStrategyMarketTest.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ contract CollectorUniswapCallback {
}

receive() external payable {
console2.log("recieved eth ", msg.value);
console2.log("received eth ", msg.value);
}
}

Expand Down
6 changes: 5 additions & 1 deletion packages/protocol-deployments/src/typedData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,11 @@ export const permitSparkCommentTypedDataDefinition = (
};
};

// todo: explain
/**
* Returns the minimum value required for a spark transaction (0.000001 ETH)
* This small amount is used to prevent spam and cover basic gas costs
* @returns The minimum spark value in wei (1e12 wei or 0.000001 ETH)
*/
export const sparkValue = () => parseEther("0.000001");

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/protocol-sdk/src/premint/premint-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export function getDataFromPremintReceipt(
const premintedLog = getPremintedLogFromReceipt(receipt);
return {
tokenId: premintedLog?.tokenId,
collectionAddres: premintedLog?.contractAddress,
collectionAddress: premintedLog?.contractAddress,
premintedLog,
urls: makeUrls({
address: premintedLog?.contractAddress,
Expand Down
2 changes: 1 addition & 1 deletion packages/sparks/src/helpers/SponsoredSparksSpender.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ contract SponsoredSparksSpender is EIP712, ERC1155TransferRecipientConstants, IS
) external onlySparks returns (bytes4) {
_onBatchReceived(from, ids, values, data);

// Validate recieving 1155 tokens in callback
// Validate receiving 1155 tokens in callback
return ON_ERC1155_BATCH_RECEIVED_HASH;
}

Expand Down