Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanture theme fix #31

Open
wants to merge 92 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
07b3b17
initial Adventure template
Danielg212 Sep 24, 2020
fc78dbf
Merge branch 'master' into danielgi
Danielg212 Sep 24, 2020
99b91bf
Merge pull request #1 from yonbav/danielgi
yonbav Sep 24, 2020
a67f427
moving section
yonbav Sep 24, 2020
989b29d
horizontal scrolling levels design
Danielg212 Sep 24, 2020
0949d0a
- creating a background to the game.
yonbav Sep 25, 2020
432a2f7
Merge branch 'master' into danielgi
yonbav Sep 25, 2020
4118337
Merge pull request #2 from yonbav/danielgi
yonbav Sep 25, 2020
3da4fad
adding the final assets
yonbav Sep 25, 2020
dbc9afd
- add first draft to education
yonbav Sep 25, 2020
8b6cf80
fixing the scroll position
yonbav Sep 27, 2020
dab39aa
remove console log
yonbav Sep 27, 2020
77b97f8
- creating moving clouds.
yonbav Sep 27, 2020
18edf53
creating a moving figure
yonbav Sep 27, 2020
31699f6
- creating a moving figure.
yonbav Sep 27, 2020
12b5d4d
remove unused state
yonbav Sep 27, 2020
661bbd0
last merge to master.
yonbav Sep 29, 2020
72fed39
basics clouds + parallax background + Utils.ts
Danielg212 Sep 29, 2020
8301fdb
Merge pull request #3 from yonbav/danielgi
Danielg212 Sep 29, 2020
1c2eb63
better clouds animation
Danielg212 Sep 29, 2020
0db0943
+skills
Danielg212 Sep 29, 2020
16742fb
skills list wrapping
Danielg212 Sep 29, 2020
3860218
Merge pull request #4 from yonbav/danielgi
Danielg212 Sep 29, 2020
2a5a39f
basic
Nemo9439 Sep 30, 2020
9c13855
merge master
Nemo9439 Sep 30, 2020
e12a55a
some progress
Nemo9439 Sep 30, 2020
1130aa6
Adding the city assets
yonbav Oct 2, 2020
e28f2c7
creating the city backgrpund
yonbav Oct 2, 2020
cb9b0b0
Merge pull request #5 from yonbav/city-background
yonbav Oct 2, 2020
5fa9e65
small fixes for city-backgrounds
yonbav Oct 2, 2020
7b7bdef
work wip
Nemo9439 Oct 5, 2020
3a3d5b6
Merge branch 'master' of github.com:yonbav/cv-boostifier-team-doom in…
Nemo9439 Oct 5, 2020
84ac37e
work design
Nemo9439 Oct 5, 2020
3e9c95b
Basics.tsx bugfix
Danielg212 Oct 5, 2020
3f5701e
Merge pull request #6 from yonbav/danielgi
yonbav Oct 7, 2020
226d63e
spliting the components
yonbav Oct 7, 2020
218fc6a
Merge branch 'master' of https://github.com/yonbav/cv-boostifier-team…
yonbav Oct 7, 2020
f4d8065
work background
Nemo9439 Oct 11, 2020
aad1e18
- creating first version of floor
yonbav Oct 17, 2020
0f8bc35
Adding male and female figures
yonbav Oct 17, 2020
b4f241c
Merge pull request #7 from yonbav/floor-and-figure
yonbav Oct 17, 2020
75a0040
small fix
yonbav Oct 17, 2020
a41a4b3
day-light parallax background on all project
Oct 19, 2020
f7b43e8
Merge pull request #8 from yonbav/danielgi
yonbav Oct 20, 2020
a300d94
education component
Nemo9439 Oct 20, 2020
7afb40b
recommendations
Nemo9439 Oct 20, 2020
d9060ae
fix indexes issue
Nemo9439 Oct 20, 2020
91860b9
all components
Nemo9439 Oct 20, 2020
3457e07
fixes
Nemo9439 Oct 22, 2020
e25d0c0
Merge pull request #9 from outbrain/master
yonbav Oct 22, 2020
ea47990
finishes
Nemo9439 Oct 22, 2020
92100ff
Merge branch 'master' of github.com:yonbav/cv-boostifier-team-doom
Nemo9439 Oct 22, 2020
5b1807b
add scroll message
Nemo9439 Oct 22, 2020
6b1efab
ohad fixes before submition
Nemo9439 Oct 22, 2020
8fb6cc0
cloud fix+ static floor+ boxes cosmetics + parallax mountains bit slower
Oct 22, 2020
1c016d2
adding a gender selection
yonbav Oct 23, 2020
eceb315
fixing the disappearing floor.
yonbav Oct 23, 2020
cbf1a97
lint
yonbav Oct 23, 2020
d353fd2
Merge branch 'master' into danielgi
yonbav Oct 24, 2020
c18cb48
Merge pull request #10 from yonbav/danielgi
yonbav Oct 24, 2020
69ccb67
fixing the floor
yonbav Oct 24, 2020
b3b8d77
placing objects in the way
yonbav Oct 24, 2020
83001c2
- remove unused backgrounds
yonbav Oct 24, 2020
e432a51
fixing the floor wiered lags
yonbav Oct 24, 2020
3b8b1fe
return interests section
yonbav Oct 24, 2020
b85d9a6
fixes of sunset
Nemo9439 Oct 25, 2020
c078433
fixes
Nemo9439 Oct 25, 2020
910126d
fix sunset
Nemo9439 Oct 25, 2020
060732b
+contact night theme + day-night transition
Oct 29, 2020
eceb208
Merge pull request #11 from yonbav/danielgi
yonbav Oct 30, 2020
c832fa3
small fixes
Nemo9439 Nov 1, 2020
b218e1d
small fixes
Nemo9439 Nov 1, 2020
09f3269
contact title+
Nov 1, 2020
db5b369
Merge pull request #12 from yonbav/danielgi
Danielg212 Nov 1, 2020
87e71be
background transition with mountains
Nov 1, 2020
b9b591e
Merge pull request #13 from yonbav/danielgi
yonbav Nov 1, 2020
cdbcb4e
background transition with mountains
Nov 1, 2020
fc0aba1
skills layout fix
Nov 2, 2020
bdf8fc3
skills layout fix
Nov 2, 2020
83646f2
Merge pull request #14 from yonbav/danielgi
yonbav Nov 2, 2020
b052731
fixes of trees and skills
Nemo9439 Nov 3, 2020
2c7c9f2
skills layout fix
Nov 3, 2020
8d05a1c
fix background url
Nemo9439 Nov 3, 2020
e076e42
added preview.png thumbnail
Nov 5, 2020
fea74b2
Merge pull request #15 from yonbav/danielgi
Danielg212 Nov 5, 2020
acb6bc4
preparing the jump assets
yonbav Nov 7, 2020
643d83a
Merge branch 'master' of https://github.com/yonbav/cv-boostifier-team…
yonbav Nov 7, 2020
b571403
Merge branch 'master' into master
tsachis Nov 12, 2020
e56594d
fix name
Nemo9439 Apr 6, 2021
78fb7b7
Merge branch 'outbrain:master' into master
Danielg212 Jan 13, 2022
67f320c
Merge branch 'master' of https://github.com/yonbav/cv-boostifier-team…
Jan 13, 2022
2d6a0a1
fix(advanture) - company name fix + contributor link
Jan 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,4 @@ yarn-error.log*

# Local Netlify folder
.netlify

# VSCode
.vscode
.vscode/*
6 changes: 3 additions & 3 deletions src/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ export interface Work {
/**
* e.g. Social Media Company
*/
description?: string;
name?: string; // name isn't shown on jsonresume org
/**
* e.g. 2012-06-29
*/
Expand All @@ -332,7 +332,7 @@ export interface Work {
/**
* e.g. Facebook
*/
name?: string;
company?: string;
/**
* e.g. Software Engineer
*/
Expand All @@ -348,7 +348,7 @@ export interface Work {
/**
* e.g. http://facebook.example.com
*/
url?: string;
website?: string;
}


Expand Down
4 changes: 2 additions & 2 deletions src/skins/Adventure/components/Work/Work.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export function WorkComponent(props: {
{utils.formatDate(work?.endDate) || "Present"}
</div>
<div className="name">
{work?.position} at{" "}
<a href={work?.url} target="_blank" rel="noopener noreferrer">
{work?.position} at {work.company}
<a href={work?.website} target="_blank" rel="noopener noreferrer">
{work?.name}
</a>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/skins/Adventure/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"displayName": "Adventure",
"createdBy": [
{
"name": "Ohad Shivak",
"name": "Ohad Shivek",
"link": "https://www.linkedin.com/in/ohadshivek"
},
{
Expand All @@ -11,7 +11,7 @@
},
{
"name": "Daniel Giat",
"link": "https://www.linkedin.com/in/daniel-giat-33512aa1/"
"link": "https://www.linkedin.com/in/daniel-giat"
}
]
}
2 changes: 1 addition & 1 deletion src/skins/Basic/Basic.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
align-items: flex-start;
flex-wrap: wrap;
word-break: break-word;

$lead-color: #124c41;
$sidebar-width: 400px;
$breakpoint: 800px;
Expand Down
2 changes: 1 addition & 1 deletion src/skins/CssTyper/CssTyper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export function CssTyper(props: PropsWithChildren<IProfileProps>) {
</div>
<div className="work-details">
<div className="position">{w.position}</div>
<div className="website"><a href={w.url || (w as any).website}>{w.url || (w as any).website}</a></div>
<div className="website"><a href={(w as any).url || w.website}>{(w as any).url || w.website}</a></div>
</div>
{w.summary && <div className="summary"><p>{w.summary}</p></div>}
{w.highlights && !!w.highlights.length && <div className="work-highlights">
Expand Down