Uneeded consts file removed

outbrain-inc · Aug 9, 2023 · e3ce4dd · e3ce4dd
1 parent 2f89c20
commit e3ce4dd
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/src/consts.rs b/src/consts.rs
diff --git a/src/lib.rs b/src/lib.rs
@@ -8,7 +8,6 @@ mod block_normalize;
 mod block_relu;
 mod cache;
 mod cmdline;
-mod consts;
 mod feature_buffer;
 mod feature_transform_executor;
 mod feature_transform_implementations;

diff --git a/src/main.rs b/src/main.rs
@@ -36,7 +36,6 @@ mod block_normalize;
 mod block_relu;
 mod cache;
 mod cmdline;
-mod consts;
 mod feature_buffer;
 mod feature_transform_executor;
 mod feature_transform_implementations;

diff --git a/src/model_instance.rs b/src/model_instance.rs
@@ -5,14 +5,16 @@ use std::io::ErrorKind;
 use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
 
-use crate::consts;
 use crate::feature_transform_parser;
 use crate::vwmap;
 use crate::vwmap::NamespaceDescriptor;
 
 const WEIGHT_DELIM: &str = ":";
 const VERBOSE_FIELD_DELIM: &str = ",";
 
+// Maximum supported FFM embedding size
+const FFM_MAX_K: usize = 128;
+
 #[derive(Serialize, Deserialize, Debug, Clone, PartialEq)]
 pub struct FeatureComboDesc {
     pub namespace_descriptors: Vec<vwmap::NamespaceDescriptor>,
@@ -364,12 +366,12 @@ impl ModelInstance {
 
         if let Some(val) = cl.value_of("ffm_k") {
             mi.ffm_k = val.parse()?;
-            if mi.ffm_k > consts::FFM_MAX_K as u32 {
+            if mi.ffm_k > FFM_MAX_K as u32 {
                 return Err(Box::new(IOError::new(
                     ErrorKind::Other,
                     format!(
                         "Maximum ffm_k is: {}, passed: {}",
-                        consts::FFM_MAX_K,
+                        FFM_MAX_K,
                         mi.ffm_k
                     ),
                 )));