feat: save gh email when login

[thormengkheang]

fix #24

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @invisal on Vercel.

@invisal first needs to authorize it.

[invisal]

This only work if the user has their email public.
https://stackoverflow.com/questions/35373995/github-user-email-is-null-despite-useremail-scope

You need to make extra request to get the email https://api.github.com/user/emails

[thormengkheang]

please check again. I check if the email is not available will fetch email from the API

[rin-yato]

I think it might be better to group all route handlers into api/, otherwise we would be mixing pages and api routes together, this affect both the file structure and also the url.

I suggest this:

• GET /login/github -> GET /api/auth/github
• GET /login/github/callback -> GET /api/auth/github/callback

What do you think?

[rin-yato]

I think it might be better to group all route handlers into api/, otherwise we would be mixing pages and api routes together, this affect both the file structure and also the url.

I suggest this:

• GET /login/github -> GET /api/auth/github
• GET /login/github/callback -> GET /api/auth/github/callback

What do you think?

Now that I look at it, it's out of scope for this issue, was bong @invisal the one who added the initial GITHUB auth?

[rin-yato]

Inside scope of the issue, everything looks good to me!

[invisal]

I think it might be better to group all route handlers into api/, otherwise we would be mixing pages and api routes together, this affect both the file structure and also the url.
I suggest this:

• GET /login/github -> GET /api/auth/github
• GET /login/github/callback -> GET /api/auth/github/callback

What do you think?

Now that I look at it, it's out of scope for this issue, was bong @invisal the one who added the initial GITHUB auth?

I am following the Lucia document. But I think it is fine, The /api folder should focus on API (which perform some action) and get some data. /login/github does not get any data. It is basically just doing the redirect.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
libsql-viewer	⬜️ Ignored (Inspect)	Visit Preview		Mar 14, 2024 1:21pm

[invisal]

LGTM