Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upload file to cell #62

Merged
merged 6 commits into from
Mar 30, 2024
Merged

Conversation

rin-yato
Copy link
Collaborator

@rin-yato rin-yato commented Mar 30, 2024

Description

  • Added an Upload File button to the cell context menu. Allowing user to upload file to R2 and set the file url into the current focused cell.
  • Added Toaster component from sonner

Tested on:

  • Arc browser running on chromium
  • Safari

Demo (1.4x speed)

cell-upload.mp4

Unauthenticated upload (1.2x speed)

unauthenticated-upload.mp4

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
libsql-viewer ⬜️ Ignored (Inspect) Visit Preview Mar 30, 2024 8:47am

@rin-yato rin-yato linked an issue Mar 30, 2024 that may be closed by this pull request
@rin-yato rin-yato requested a review from invisal March 30, 2024 07:56
@rin-yato rin-yato force-pushed the feat/upload-file-to-cell-#51 branch from 5ddfe52 to c8dc85e Compare March 30, 2024 07:57
@rin-yato rin-yato linked an issue Mar 30, 2024 that may be closed by this pull request
Copy link
Collaborator

@invisal invisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@invisal invisal merged commit 1f0a06a into develop Mar 30, 2024
3 checks passed
@invisal invisal deleted the feat/upload-file-to-cell-#51 branch April 26, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload file to the cell value Show error message when try to upload image without login
2 participants