Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): stop safari from opening the native menu #89

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

rin-yato
Copy link
Collaborator

@rin-yato rin-yato commented Apr 26, 2024

This PR change the cancelable: false to cancelable: true in the context menu MouseEvent.

This allow the event to be prevented, e.g. e.preventDefault()
https://developer.mozilla.org/en-US/docs/Web/API/Event/cancelable

context-menu.mp4

closes #85

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
libsql-studio-preview ⬜️ Ignored (Inspect) Apr 26, 2024 1:41pm
libsql-viewer ⬜️ Ignored (Inspect) Apr 26, 2024 1:41pm

@rin-yato rin-yato requested a review from invisal April 26, 2024 13:41
@rin-yato rin-yato linked an issue Apr 26, 2024 that may be closed by this pull request
@invisal
Copy link
Collaborator

invisal commented Apr 26, 2024

Super!

@invisal invisal merged commit 83acfb8 into develop Apr 27, 2024
4 checks passed
@rin-yato rin-yato deleted the yato/85-fix-safari-context-menu branch April 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari context menu conflict with our context menu
2 participants