Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add export for whole query result #95

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

invisal
Copy link
Collaborator

@invisal invisal commented Jun 12, 2024

I have added the mock-up design

You follow these code for export
https://github.com/invisal/libsql-studio/blob/develop/gui/src/components/query-result-table.tsx#L370

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
libsql-studio-preview ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 7:46am
libsql-viewer ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 7:46am

@invisal invisal changed the title feat: add design for export feat: add export for whole query result Jun 12, 2024
@invisal invisal linked an issue Jun 12, 2024 that may be closed by this pull request
data: OptimizeTableState;
}) {
const onExportClicked = useCallback(() => {
// do something here
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add implementation here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank i'll work on it when i got the time

Copy link
Collaborator Author

@invisal invisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSV does not work properly. Try to open export.csv in Excel

@invisal invisal marked this pull request as ready for review June 20, 2024 11:09
@invisal
Copy link
Collaborator Author

invisal commented Jun 20, 2024

LGTM

@invisal invisal merged commit ebebcf2 into develop Jun 20, 2024
4 checks passed
@invisal invisal deleted the export-whole-result branch October 26, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export result as CSV and JSON
3 participants