Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for spot instances #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wrbooth
Copy link
Contributor

@wrbooth wrbooth commented Mar 22, 2023

Changed the following to allow for spot instance support:

  • added ec2_spot and fargate_spot to batch_type variable
  • added a splotfleet iam role (generated when a spot batch_type is selected)
  • refactored compute environment type selection

Tested on my own environment via ec2_spot. I did not test fargate_spot.

Testing Screenshots

Functioning compute environment

Screen Shot 2023-03-21 at 8 56 10 PM

Successful Metaflow run on spot ec2 instances

Screen Shot 2023-03-21 at 8 57 07 PM

@dkarlo2
Copy link

dkarlo2 commented Aug 30, 2023

Hi there, what's the status of this PR? I'm also looking for spot instances support (fargate_spot in my case).
Is there anything I can do to speed this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants