fix s3ReadableStream

oven-sh · Dec 28, 2024 · 23e416f · 23e416f
1 parent ade72ec
commit 23e416f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/src/s3.zig b/src/s3.zig
@@ -1353,15 +1353,6 @@ pub const AWSCredentials = struct {
                         );
                         return;
                     }
-                    if (chunk.list.items.len == 0) {
-                        readable.ptr.Bytes.onData(
-                            .{
-                                .done = {},
-                            },
-                            bun.default_allocator,
-                        );
-                        return;
-                    }
                     readable.ptr.Bytes.onData(
                         .{
                             .temporary_and_done = bun.ByteList.initConst(chunk.list.items),
@@ -1371,8 +1362,6 @@ pub const AWSCredentials = struct {
                     return;
                 }
             }
-            var buffer = chunk;
-            buffer.deinit();
         }
 
         pub fn deinit(this: *@This()) void {

diff --git a/test/js/bun/s3/s3-stream-leak-fixture.js b/test/js/bun/s3/s3-stream-leak-fixture.js
diff --git a/test/js/bun/s3/s3.test.ts b/test/js/bun/s3/s3.test.ts
@@ -620,7 +620,7 @@ describe.skipIf(!s3Options.accessKeyId)("s3", () => {
     it(
       "fsFile.stream() should not leak",
       async () => {
-        const dir = tempDirWithFiles("bun-write-leak-fixture", {
+        const dir = tempDirWithFiles("s3-stream-leak-fixture", {
           "s3-stream-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "s3-stream-leak-fixture.js")).text(),
           "out.bin": "here",
         });
@@ -651,7 +651,7 @@ describe.skipIf(!s3Options.accessKeyId)("s3", () => {
     it(
       "fsFile.writer().write() should not leak",
       async () => {
-        const dir = tempDirWithFiles("bun-write-leak-fixture", {
+        const dir = tempDirWithFiles("s3-writer-leak-fixture", {
           "s3-writer-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "s3-writer-leak-fixture.js")).text(),
           "out.bin": "here",
         });