fix: memory leak when reading chunks from a stream

oven-sh · Dec 31, 2024 · 3274514 · 3274514
1 parent e96dded
commit 3274514
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/bun.js/webcore/streams.zig b/src/bun.js/webcore/streams.zig
@@ -709,6 +709,8 @@ pub const StreamResult = union(Tag) {
         switch (this.*) {
             .owned => |*owned| owned.deinitWithAllocator(bun.default_allocator),
             .owned_and_done => |*owned_and_done| owned_and_done.deinitWithAllocator(bun.default_allocator),
+            .temporary => |*temporary| temporary.deinitWithAllocator(bun.default_allocator),
+            .temporary_and_done => |*temporary_and_done| temporary_and_done.deinitWithAllocator(bun.default_allocator),
             .err => |err| {
                 if (err == .JSValue) {
                     err.JSValue.unprotect();
@@ -1021,6 +1023,12 @@ pub const StreamResult = union(Tag) {
                 const value = result.toJS(globalThis);
                 value.ensureStillAlive();
 
+                switch (result.*) {
+                    .temporary, .temporary_and_done => {
+                        result.deinit();
+                    },
+                    else => {},
+                }
                 result.* = .{ .temporary = .{} };
                 promise.resolve(globalThis, value);
             },