Skip to content

Commit

Permalink
leak test in their own file
Browse files Browse the repository at this point in the history
  • Loading branch information
@cirospaciari
cirospaciari committed Dec 28, 2024
1 parent af4ea94 commit 61d0690
Show file tree
Hide file tree
Showing 2 changed files with 109 additions and 96 deletions.
109 changes: 109 additions & 0 deletions test/js/bun/s3/s3.leak.test.ts
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
import { describe, expect, it } from "bun:test";
import { bunExe, bunEnv, getSecret, tempDirWithFiles } from "harness";
import type { S3FileOptions } from "bun";
import path from "path";
const s3Options: S3FileOptions = {
accessKeyId: getSecret("S3_R2_ACCESS_KEY"),
secretAccessKey: getSecret("S3_R2_SECRET_KEY"),
endpoint: getSecret("S3_R2_ENDPOINT"),
};

const S3Bucket = getSecret("S3_R2_BUCKET");

describe.skipIf(!s3Options.accessKeyId)("s3", () => {
describe("leak tests", () => {
it(
"fsFile.stream() should not leak",
async () => {
const dir = tempDirWithFiles("s3-stream-leak-fixture", {
"s3-stream-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "s3-stream-leak-fixture.js")).text(),
"out.bin": "here",
});

const dest = path.join(dir, "out.bin");

const { exitCode, stderr } = Bun.spawnSync(
[bunExe(), "--smol", path.join(dir, "s3-stream-leak-fixture.js"), dest],
{
env: {
...bunEnv,
BUN_JSC_gcMaxHeapSize: "503316",
AWS_ACCESS_KEY_ID: s3Options.accessKeyId,
AWS_SECRET_ACCESS_KEY: s3Options.secretAccessKey,
AWS_ENDPOINT: s3Options.endpoint,
AWS_BUCKET: S3Bucket,
},
stderr: "pipe",
stdout: "inherit",
stdin: "ignore",
},
);
expect(exitCode).toBe(0);
expect(stderr.toString()).toBe("");
},
30 * 1000,
);
it(
"fsFile.writer().write() should not leak",
async () => {
const dir = tempDirWithFiles("s3-writer-leak-fixture", {
"s3-writer-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "s3-writer-leak-fixture.js")).text(),
"out.bin": "here",
});

const dest = path.join(dir, "out.bin");

const { exitCode, stderr } = Bun.spawnSync(
[bunExe(), "--smol", path.join(dir, "s3-writer-leak-fixture.js"), dest],
{
env: {
...bunEnv,
BUN_JSC_gcMaxHeapSize: "503316",
AWS_ACCESS_KEY_ID: s3Options.accessKeyId,
AWS_SECRET_ACCESS_KEY: s3Options.secretAccessKey,
AWS_ENDPOINT: s3Options.endpoint,
AWS_BUCKET: S3Bucket,
},
stderr: "pipe",
stdout: "inherit",
stdin: "ignore",
},
);
expect(exitCode).toBe(0);
expect(stderr.toString()).toBe("");
},
30 * 1000,
);
it(
"Bun.write should not leak",
async () => {
const dir = tempDirWithFiles("bun-write-leak-fixture", {
"bun-write-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "bun-write-leak-fixture.js")).text(),
"out.bin": "here",
});

const dest = path.join(dir, "out.bin");

const { exitCode, stderr } = Bun.spawnSync(
[bunExe(), "--smol", path.join(dir, "bun-write-leak-fixture.js"), dest],
{
env: {
...bunEnv,
BUN_JSC_gcMaxHeapSize: "503316",
AWS_ACCESS_KEY_ID: s3Options.accessKeyId,
AWS_SECRET_ACCESS_KEY: s3Options.secretAccessKey,
AWS_ENDPOINT: s3Options.endpoint,
AWS_BUCKET: S3Bucket,
},
stderr: "pipe",
stdout: "inherit",
stdin: "ignore",
},
);
expect(exitCode).toBe(0);
expect(stderr.toString()).toBe("");
},
30 * 1000,
);
});
});
96 changes: 0 additions & 96 deletions test/js/bun/s3/s3.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -615,100 +615,4 @@ describe.skipIf(!s3Options.accessKeyId)("s3", () => {
await s3file.unlink();
});
});

describe("leak tests", () => {
it(
"fsFile.stream() should not leak",
async () => {
const dir = tempDirWithFiles("s3-stream-leak-fixture", {
"s3-stream-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "s3-stream-leak-fixture.js")).text(),
"out.bin": "here",
});

const dest = path.join(dir, "out.bin");

const { exitCode, stderr } = Bun.spawnSync(
[bunExe(), "--smol", path.join(dir, "s3-stream-leak-fixture.js"), dest],
{
env: {
...bunEnv,
BUN_JSC_gcMaxHeapSize: "503316",
AWS_ACCESS_KEY_ID: s3Options.accessKeyId,
AWS_SECRET_ACCESS_KEY: s3Options.secretAccessKey,
AWS_ENDPOINT: s3Options.endpoint,
AWS_BUCKET: S3Bucket,
},
stderr: "pipe",
stdout: "inherit",
stdin: "ignore",
},
);
expect(exitCode).toBe(0);
expect(stderr.toString()).toBe("");
},
30 * 1000,
);
it(
"fsFile.writer().write() should not leak",
async () => {
const dir = tempDirWithFiles("s3-writer-leak-fixture", {
"s3-writer-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "s3-writer-leak-fixture.js")).text(),
"out.bin": "here",
});

const dest = path.join(dir, "out.bin");

const { exitCode, stderr } = Bun.spawnSync(
[bunExe(), "--smol", path.join(dir, "s3-writer-leak-fixture.js"), dest],
{
env: {
...bunEnv,
BUN_JSC_gcMaxHeapSize: "503316",
AWS_ACCESS_KEY_ID: s3Options.accessKeyId,
AWS_SECRET_ACCESS_KEY: s3Options.secretAccessKey,
AWS_ENDPOINT: s3Options.endpoint,
AWS_BUCKET: S3Bucket,
},
stderr: "pipe",
stdout: "inherit",
stdin: "ignore",
},
);
expect(exitCode).toBe(0);
expect(stderr.toString()).toBe("");
},
30 * 1000,
);
it(
"Bun.write should not leak",
async () => {
const dir = tempDirWithFiles("bun-write-leak-fixture", {
"bun-write-leak-fixture.js": await Bun.file(path.join(import.meta.dir, "bun-write-leak-fixture.js")).text(),
"out.bin": "here",
});

const dest = path.join(dir, "out.bin");

const { exitCode, stderr } = Bun.spawnSync(
[bunExe(), "--smol", path.join(dir, "bun-write-leak-fixture.js"), dest],
{
env: {
...bunEnv,
BUN_JSC_gcMaxHeapSize: "503316",
AWS_ACCESS_KEY_ID: s3Options.accessKeyId,
AWS_SECRET_ACCESS_KEY: s3Options.secretAccessKey,
AWS_ENDPOINT: s3Options.endpoint,
AWS_BUCKET: S3Bucket,
},
stderr: "pipe",
stdout: "inherit",
stdin: "ignore",
},
);
expect(exitCode).toBe(0);
expect(stderr.toString()).toBe("");
},
30 * 1000,
);
});
});

0 comments on commit 61d0690

Please sign in to comment.