fix: make raiseIgnoringPanicHandler ignore the panic handler #12578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit has failing tests :( 🐧💪 1 failing tests Linux AARCH64
🪟💻 4 failing tests Windows x64 baseline
🪟💻 2 failing tests Windows x64
|
|
will need to have a test |
paperclover
force-pushed
the
dave/raise-ignoring-panic-handler
branch
from
873d39d to
6d5945c
Compare
paperclover
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: paperdave <[email protected]> Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I guess the new panic handler is so good at handling crashes that the method used before in
raiseIgnoringPanicHandlerwas not actually ignoring it. This definitely happened on windows, considering there was no code at all to reset signal handlers.We have a function for this:
bun.crash_handler.resetSegfaultHandler();. We just invoke that now!