Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix the rest of test-process #16026

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
9e0adfe
fix test-process-warning.js
nektro Dec 28, 2024
d12a3d2
stub out node:test
nektro Dec 28, 2024
9b25f5a
fix test-process-umask.js
nektro Dec 28, 2024
9d3fddf
fix test-process-umask-mask.js
nektro Dec 28, 2024
8f161ea
fix test-process-uid-gid.js
nektro Dec 28, 2024
295cbc0
fix test-process-title-cli.js
nektro Dec 28, 2024
13da098
don't lowercase Error instance printing
nektro Dec 28, 2024
0b1f020
fix test-process-setgroups.js
nektro Dec 28, 2024
e4bf5e5
fix test-process-release.js
nektro Dec 28, 2024
218c673
fix test-process-really-exit.js
nektro Dec 28, 2024
ca2a61e
fix
nektro Dec 28, 2024
2ebba0a
fix test-process-no-deprecation.js
nektro Dec 28, 2024
908287f
fix test-process-kill-pid.js
nektro Dec 28, 2024
24609c2
fix test-process-hrtime.js
nektro Dec 28, 2024
7f0adc1
tidy
nektro Dec 28, 2024
9227ca6
fix test-process-get-builtin.mjs
nektro Dec 31, 2024
e8e9e37
fix test-process-exit-code-validation.js
nektro Dec 31, 2024
1be1f0c
fix test-process-exception-capture-errors.js
nektro Dec 31, 2024
3f8a948
fix test-process-euid-egid.js
nektro Dec 31, 2024
c9fc1ed
fix test-process-emitwarning.js
nektro Dec 31, 2024
4d3d51e
fix test-process-dlopen-error-message-crash.js
nektro Dec 31, 2024
297091a
fix test-process-cpuUsage.js
nektro Dec 31, 2024
e7ab2d0
fix test-process-constrained-memory.js
nektro Dec 31, 2024
863c03e
fix test-process-config.js
nektro Dec 31, 2024
652e8d4
fix test-process-chdir.js
nektro Dec 31, 2024
0fa6ab4
add code missing from 24609c27cb
nektro Dec 31, 2024
5e834d1
zig: make FileSystem.top_level_dir nul-terminated
nektro Dec 31, 2024
6a51431
fix test-process-chdir-errormessage.js
nektro Dec 31, 2024
bee3360
fill in some errnoSys variants
nektro Jan 1, 2025
19febc6
fix test-process-binding-util.js
nektro Jan 1, 2025
2f66a40
fix test-process-beforeexit-throw-exit.js
nektro Jan 1, 2025
b84078f
fix test-process-available-memory.js
nektro Jan 1, 2025
fe3a953
make process constructor callable
nektro Jan 1, 2025
77ad70f
fix test-process-assert.js
nektro Jan 1, 2025
d098c67
fix test-child-process-stdio.js
nektro Jan 1, 2025
b2e5ac7
fix test-process-beforeexit.js
nektro Jan 1, 2025
4a93608
Merge remote-tracking branch 'origin/main' into nektro-patch-18634
nektro Jan 1, 2025
96c1339
fixes
nektro Jan 1, 2025
0a97612
lower flaky test retry count
nektro Jan 1, 2025
8da2df3
fixes
nektro Jan 1, 2025
cb1088e
fix
nektro Jan 2, 2025
9e3cd74
fix
nektro Jan 2, 2025
cc2730c
fix
nektro Jan 2, 2025
501794b
fix
nektro Jan 2, 2025
301bbd5
[skip ci] update docs
nektro Jan 3, 2025
a0c16bd
address review
nektro Jan 3, 2025
4113435
more startup time improvement
nektro Jan 3, 2025
b15a1b3
address review
nektro Jan 3, 2025
ae1b9f3
oops fix compile error
nektro Jan 3, 2025
e591cd1
unimplement process.getBuiltinModule
nektro Jan 3, 2025
be4552f
address review
nektro Jan 3, 2025
73efb0f
fixes
nektro Jan 3, 2025
7e72c75
fixes
nektro Jan 3, 2025
d9f2662
address review
nektro Jan 4, 2025
96e3185
Merge remote-tracking branch 'origin/main' into nektro-patch-18634
nektro Jan 4, 2025
c88d4c8
mutex guard process.title getter too
nektro Jan 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/runtime/nodejs-apis.md
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ The table below lists all globals implemented by Node.js and Bun's current compa

### [`process`](https://nodejs.org/api/process.html)

🟡 Missing `domain` `initgroups` `setegid` `seteuid` `setgid` `setgroups` `setuid` `allowedNodeEnvironmentFlags` `getActiveResourcesInfo` `setActiveResourcesInfo` `moduleLoadList` `setSourceMapsEnabled`. `process.binding` is partially implemented.
🟡 Missing `initgroups` `allowedNodeEnvironmentFlags` `getActiveResourcesInfo` `setActiveResourcesInfo` `moduleLoadList` `setSourceMapsEnabled`. `process.binding` is partially implemented.

### [`queueMicrotask()`](https://developer.mozilla.org/en-US/docs/Web/API/queueMicrotask)

Expand Down
2 changes: 1 addition & 1 deletion src/api/schema.zig
Original file line number Diff line number Diff line change
Expand Up @@ -1631,7 +1631,7 @@ pub const Api = struct {
origin: ?[]const u8 = null,

/// absolute_working_dir
absolute_working_dir: ?[]const u8 = null,
absolute_working_dir: ?[:0]const u8 = null,

/// define
define: ?StringMap = null,
Expand Down
2 changes: 1 addition & 1 deletion src/bake/DevServer.zig
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub const igLog = bun.Output.scoped(.IncrementalGraph, false);
pub const Options = struct {
/// Arena must live until DevServer.deinit()
arena: Allocator,
root: []const u8,
root: [:0]const u8,
vm: *VirtualMachine,
framework: bake.Framework,
bundler_options: bake.SplitBundlerOptions,
Expand Down
6 changes: 3 additions & 3 deletions src/bake/bake.zig
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub const UserOptions = struct {
arena: std.heap.ArenaAllocator,
allocations: StringRefList,

root: []const u8,
root: [:0]const u8,
framework: Framework,
bundler_options: SplitBundlerOptions,

Expand Down Expand Up @@ -78,9 +78,9 @@ pub const UserOptions = struct {
const StringRefList = struct {
strings: std.ArrayListUnmanaged(ZigString.Slice),

pub fn track(al: *StringRefList, str: ZigString.Slice) []const u8 {
pub fn track(al: *StringRefList, str: ZigString.Slice) [:0]const u8 {
al.strings.append(bun.default_allocator, str) catch bun.outOfMemory();
return str.slice();
return str.sliceZ();
}

pub fn free(al: *StringRefList) void {
Expand Down
1 change: 0 additions & 1 deletion src/bun.js/bindings/BunObject.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ JSC_DEFINE_HOST_FUNCTION(functionConcatTypedArrays, (JSGlobalObject * globalObje
auto arg2 = callFrame->argument(2);
if (!arg2.isUndefined()) {
asUint8Array = arg2.toBoolean(globalObject);
RETURN_IF_EXCEPTION(throwScope, {});
}

return flattenArrayOfBuffersIntoArrayBufferOrUint8Array(globalObject, arrayValue, maxLength, asUint8Array);
Expand Down
Loading
Loading