Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle bundle(d)Dependencies in bun install #16055

Merged
merged 13 commits into from
Dec 31, 2024

Conversation

dylan-conway
Copy link
Member

@dylan-conway dylan-conway commented Dec 30, 2024

What does this PR do?

Avoids installing bundle(d)Dependencies, and uses them in the resolution graph to prevent overwriting with another version.

closes #8780
fixes #10368

How did you verify your code works?

tests:

  • "bundleDependencies": true
  • with binary lockfile
  • with text lockfile
  • transitive dependency collision, one bundled one not bundled
  • npm, git, folder, and workspaces with bundledDependencies

@robobun
Copy link

robobun commented Dec 30, 2024

Updated 1:07 PM PT - Dec 31st, 2024

@dylan-conway, your commit c9645d5 has 2 failures in #8744:


🧪   try this PR locally:

bunx bun-pr 16055

@dylan-conway dylan-conway marked this pull request as ready for review December 31, 2024 01:01
@Jarred-Sumner Jarred-Sumner merged commit 5058bd3 into main Dec 31, 2024
64 of 67 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/bundled-dependencies branch December 31, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun install failed with v1.1.4 Support bundledDependencies in bun install
3 participants