fix: memory leak when reading chunks from a stream #16075
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonIsaac
commented
Dec 31, 2024
| .temporary => |*temporary| temporary.deinitWithAllocator(bun.default_allocator), | ||
| .temporary_and_done => |*temporary_and_done| temporary_and_done.deinitWithAllocator(bun.default_allocator), | ||
| else => {}, | ||
| } | ||
| result.* = .{ .temporary = .{} }; |
There was a problem hiding this comment.
Will this cause JSValues for .owned, etc. variants to point to leaked/undefined memory?
There was a problem hiding this comment.
Does line 1046 move or borrow?
Man I miss Rust's borrow checker...
| @@ -1021,6 +1023,11 @@ pub const StreamResult = union(Tag) { | |||
| const value = result.toJS(globalThis); | |||
| value.ensureStillAlive(); | |||
|
|
|||
| switch (result.*) { | |||
| .temporary => |*temporary| temporary.deinitWithAllocator(bun.default_allocator), | |||
There was a problem hiding this comment.
temporary should mean that the StreamResult don't own the data and should be cloned, the owner (how created the StreamResult) should free it.
|
I'm skeptical this is either the cause or the fix. More likely, we're not reporting the memory allocated in ArrayBufferSink to the GC, so it has no idea we allocated a bunch of memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12198