fix: dropdown problem rendering issue on light theme (#110)

overhangio · Dec 3, 2024 · 5891123 · 5891123
1 parent e35b0d9
commit 5891123
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/changelog.d/20241203_174019_dawoud.sheraz_fix_dropdown_rendering.md b/changelog.d/20241203_174019_dawoud.sheraz_fix_dropdown_rendering.md
@@ -0,0 +1,2 @@
+- [Bugfix] Fix dropdown select rendering issue on light theme (by @dawoudsheraz)
+  - ".wrapper-problem-response" did not need any dark theme variables outside dark-theme class for dropdown problems. This was causing the dropdown to use dark theme variables regardless of the theme that user selected.
diff --git a/tutorindigo/templates/indigo/lms/static/sass/xblock/_xblock.scss b/tutorindigo/templates/indigo/lms/static/sass/xblock/_xblock.scss
@@ -266,9 +266,3 @@
         }
     }
 }
-.wrapper-problem-response {
-    select {
-        background: transparent;
-        color: $text-color-d;
-    }
-}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		- [Bugfix] Fix dropdown select rendering issue on light theme (by @dawoudsheraz)
		- ".wrapper-problem-response" did not need any dark theme variables outside dark-theme class for dropdown problems. This was causing the dropdown to use dark theme variables regardless of the theme that user selected.