feat: create volume for private LMS/CMS media assets #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content Libraries will store asset files like images, transcripts, and PDFs using Learning Core–which in turn uses django-storages and expects some backing file store. These files should NOT be directly accessible via the browser, both because of access policies and the fact that the filenames will not be meaningful by themselves and must be translated by app logic. For details see: * https://github.com/openedx/openedx-learning/blob/main/docs/decisions/0015-serving-static-assets.rst * https://github.com/openedx/openedx-learning/blob/main/openedx_learning/apps/authoring/contents/models.py * https://github.com/openedx/openedx-learning/blob/main/openedx_learning/apps/authoring/components/models.py The existing /data/openedx-media -> /openedx/media mount is publicly accessible by browser, and so is not appropriate for this purpose. This commit creates a parallel /data/openedx-media-private -> /openedx/media-private volume mapping instead. This commit also creates configuration needed for openedx-learning to point to this new directory. This commit does NOT currently add support for this in k8s, as that will require changes to the minio plugin.
ormsbee
commented
Sep 26, 2024
| @@ -246,5 +246,14 @@ | |||
| "user": None, | |||
| } | |||
|
|
|||
| LEARNING_CORE = { | |||
There was a problem hiding this comment.
Actually, I should probably make this OPENEDX_LEARNING, to reduce confusion...
…s where it's from
This was referenced Sep 27, 2024
|
✅ I tested this using these instructions and it's working well. |
kdmccormick
reviewed
Oct 2, 2024
kdmccormick
approved these changes
Oct 2, 2024
|
Here's the corresponding MinIO issue: overhangio/tutor-minio#48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content Libraries will store asset files like images, transcripts, and PDFs using Learning Core–which in turn uses django-storages and expects some backing file store. These files should NOT be directly accessible via the browser, both because of access policies and the fact that the filenames will not be meaningful by themselves and must be translated by app logic. For details see:
The existing /data/openedx-media -> /openedx/media mount is publicly accessible by browser, and so is not appropriate for this purpose. This commit creates a parallel /data/openedx-media-private -> /openedx/media-private volume mapping instead.
This commit also creates configuration needed for openedx-learning to point to this new directory.
This commit does NOT currently add support for this in k8s, as that will require changes to the minio plugin.