Fix script-related crashes on exiting a domain #1251
Merged
+61
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HifiExperiments
requested changes
Nov 23, 2024
| blockingCall ? Qt::BlockingQueuedConnection : Qt::QueuedConnection); | ||
| // Lambda is necessary there to keep shared_ptr counter above zero | ||
| QMetaObject::invokeMethod(this, [=, manager = shared_from_this()]{ | ||
| manager->unloadAllEntityScripts(blockingCall ? Qt::BlockingQueuedConnection : Qt::QueuedConnection); |
There was a problem hiding this comment.
this takes in a bool, should it just pass blockingCall?
There was a problem hiding this comment.
actually I guess to get the same behavior, the invoke needs to be blocking or not
There was a problem hiding this comment.
Thank you for spotting this! I'll have a fix soon.
I'll also take a look how it's used, since blocking call invoked from main thread often means a deadlock. I might add an assert or warning there too.
HifiExperiments
approved these changes
Nov 23, 2024
HifiExperiments
added
the
CR approved
daleglass
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashes were caused by script engine getting deleted while the invoke call was waiting to be processed. Capturing shared_ptr with lambda prevents that and pointer gets released after the lambda gets processed.
Fixes #1245