fix(mrc): icon actionmenu compact ellipsisvertical (#14176)

Fixed a bug that prevented to set custom icon ref: 14172 Signed-off-by: Tristan WAGNER <[email protected]>
ovh · Nov 20, 2024 · 7a3f02a · 7a3f02a
1 parent 6bc40ca
commit 7a3f02a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/...ages/manager-react-components/src/components/navigation/menus/action/action.component.tsx b/...ages/manager-react-components/src/components/navigation/menus/action/action.component.tsx
@@ -98,9 +98,10 @@ export const ActionMenu: React.FC<ActionMenuProps> = ({
           onClick={() => setIsTrigger(true)}
           {...(!isCompact && { label: t('common_actions') })}
           icon={
-            icon ?? isCompact
-              ? ODS_ICON_NAME.ellipsisHorizontal
-              : ODS_ICON_NAME.chevronDown
+            icon ||
+            (isCompact
+              ? ODS_ICON_NAME.ellipsisVertical
+              : ODS_ICON_NAME.chevronDown)
           }
         />
       </div>

diff --git a/packages/manager-react-components/src/components/navigation/menus/action/action.spec.tsx b/packages/manager-react-components/src/components/navigation/menus/action/action.spec.tsx
@@ -64,12 +64,12 @@ describe('ActionMenu', () => {
     const actionMenuIcon = screen.getByTestId(
       'navigation-action-trigger-action',
     );
-    expect(actionMenuIcon.getAttribute('icon')).toBe('ellipsis-horizontal');
+    expect(actionMenuIcon.getAttribute('icon')).toBe('ellipsis-vertical');
   });
 
   it('renders compact menu with custom icon menu correctly', async () => {
     await setupSpecTest({
-      icon: ODS_ICON_NAME.ellipsisVertical,
+      icon: ODS_ICON_NAME.ellipsisHorizontal,
     });
     const actionMenuIcon = screen.getByTestId(
       'navigation-action-trigger-action',