Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-load-balancer): add delete l7 rules modal #13541

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat(pci-load-balancer): add delete l7 rules modal #13541

merged 1 commit into from
Oct 11, 2024

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Oct 10, 2024 •
edited
Loading

ref: DTCORE-2646

Question Answer
Branch? feat/pci-load-balancer
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-2646
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners October 10, 2024 12:59
@kqesar kqesar requested review from frenautvh, seven-amid, tibs245, MaximeBajeux and anooparveti and removed request for a team October 10, 2024 12:59
@kqesar
feat(pci-load-balancer): add delete l7 rules modal
05a3fe1 
ref: DTCORE-2646
Signed-off-by: Yoann Fievez <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kqesar kqesar merged commit 73118f8 into feat/DTCORE-2643 Oct 11, 2024
13 of 14 checks passed
@kqesar kqesar deleted the feat/DTCORE-2646 branch October 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven-amid seven-amid seven-amid approved these changes

@frenautvh frenautvh frenautvh approved these changes

@sidlynx sidlynx sidlynx approved these changes

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kqesar @sidlynx @frenautvh @seven-amid