Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci-load-balancer): uix fixes and refacto #13545

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix(pci-load-balancer): uix fixes and refacto #13545

merged 1 commit into from
Oct 10, 2024

Conversation

seven-amid
Copy link
Contributor

  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@seven-amid seven-amid requested review from a team as code owners October 10, 2024 13:21
@seven-amid seven-amid requested review from sidlynx, kqesar, antonymarion, oalkabouss and ghyenne and removed request for a team October 10, 2024 13:21
@github-actions github-actions bot added the bug Something isn't working label Oct 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@seven-amid seven-amid merged commit cee0ab5 into feat/pci-load-balancer Oct 10, 2024
13 of 14 checks passed
@seven-amid seven-amid deleted the fix/load-balancer-fixes branch October 10, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh frenautvh approved these changes

@kqesar kqesar kqesar approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seven-amid @kqesar @frenautvh