Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hycu): add hycu dashboard #13642

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat(hycu): add hycu dashboard #13642

merged 1 commit into from
Oct 21, 2024

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Oct 17, 2024

Question Answer
Branch? feat/hycu
Bug fix? no
New feature? yes
Breaking change? no
Tickets Feat #MANAGER-14499
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

@tibs245 tibs245 requested review from a team as code owners October 17, 2024 13:04
@tibs245 tibs245 requested review from kqesar, frenautvh, qpavy, anooparveti and JacquesLarique and removed request for a team October 17, 2024 13:04
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Oct 17, 2024
Copy link
Contributor

github-actions bot commented Oct 17, 2024

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@babel/types UPDATED 7.25.7 7.25.8
@testing-library/react-hooks ADDED - 8.0.1
react-error-boundary ADDED - 3.1.4

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 17, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other projects I observed that the folder which contains TS types is usually named "types"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's error but type folder already exists. I will move it after on refactor pr

Base automatically changed from feat/hycu to release/hpc-enabler-w43 October 18, 2024 08:22
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 18, 2024
@tibs245 tibs245 changed the base branch from release/hpc-enabler-w43 to feat/hycu October 21, 2024 08:06
@tibs245 tibs245 force-pushed the feat/hycu-dashboard branch 2 times, most recently from 7d8c178 to 89230c6 Compare October 21, 2024 08:56
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 21, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 21, 2024
ref: MANAGER-14499

Signed-off-by: Thibault Barske <[email protected]>
Copy link

sonarcloud bot commented Oct 21, 2024

@tibs245 tibs245 merged commit 7c41b45 into feat/hycu Oct 21, 2024
12 of 13 checks passed
@tibs245 tibs245 deleted the feat/hycu-dashboard branch October 21, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants