Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(pci-load-balancer): add unit tests #13666

Merged
merged 2 commits into from
Oct 30, 2024
Merged

test(pci-load-balancer): add unit tests #13666

merged 2 commits into from
Oct 30, 2024

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Oct 18, 2024

ref: DTCORE-2770

Question Answer
Branch? feat/pci-load-balancer
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-2770
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners October 18, 2024 08:51
@kqesar kqesar requested review from frenautvh, seven-amid, antonymarion, MaximeBajeux and JacquesLarique and removed request for a team October 18, 2024 08:51
@kqesar kqesar marked this pull request as draft October 18, 2024 08:51
@github-actions github-actions bot added the feature New feature label Oct 18, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 22, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 23, 2024
@kqesar kqesar force-pushed the feat/DTCORE-2770 branch 4 times, most recently from ac0b94e to cfd2713 Compare October 25, 2024 13:01
@kqesar kqesar marked this pull request as ready for review October 25, 2024 13:56
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Oct 28, 2024
@kqesar
test(pci-load-balancer): add unit tests
62a41f0 
ref: DTCORE-2770
Signed-off-by: Yoann Fievez <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 28, 2024
@kqesar
feat(pci-load-balancer): add modal to change pool name
96c0d28 
ref: DTCORE-2652
Signed-off-by: Yoann Fievez <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15 Security Hotspots

See analysis details on SonarCloud

@kqesar kqesar merged commit 1e055c7 into feat/pci-load-balancer Oct 30, 2024
12 of 13 checks passed
@kqesar kqesar deleted the feat/DTCORE-2770 branch October 30, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven-amid seven-amid seven-amid approved these changes

@frenautvh frenautvh frenautvh approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kqesar @frenautvh @seven-amid