Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kube): add savings plan banner #13708

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(kube): add savings plan banner #13708

wants to merge 1 commit into from
+30 −17

Conversation

lionel95200x
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? yes/no
Tickets Fix #TAPC-1911
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add savings plan banner on kubernetes

Related

@lionel95200x lionel95200x requested review from a team as code owners October 21, 2024 15:19
fredericvilcot
fredericvilcot previously approved these changes Oct 21, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot left review comments

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel95200x @fredericvilcot