Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hycu): add tracking #13922

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(hycu): add tracking #13922

wants to merge 1 commit into from
+178 −25

Conversation

ThibaudCrespin
Copy link
Contributor

@ThibaudCrespin ThibaudCrespin commented Nov 4, 2024 •
edited
Loading

ref: MANAGER-14800

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #MANAGER-14800
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Create and update tracking and related configurations for HYCU pages and interactions

Related

@github-actions github-actions bot added the feature New feature label Nov 4, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 13, 2024
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed has conflicts Has conflicts to resolve before merging labels Nov 13, 2024
@ThibaudCrespin ThibaudCrespin marked this pull request as ready for review November 14, 2024 11:10
@ThibaudCrespin ThibaudCrespin requested review from a team as code owners November 14, 2024 11:10
@ThibaudCrespin ThibaudCrespin requested review from sidlynx, seven-amid, tibs245, oalkabouss and anooparveti and removed request for a team November 14, 2024 11:10
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Nov 14, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 15, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 19, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 19, 2024
@tibs245 tibs245 force-pushed the feat/hycu branch 2 times, most recently from c492a03 to c65ba22 Compare November 19, 2024 13:14
Base automatically changed from feat/hycu to release/hycu November 19, 2024 14:09
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 20, 2024
darsene
darsene previously approved these changes Nov 20, 2024
View reviewed changes
@tibs245
Copy link
Contributor

tibs245 commented Nov 20, 2024 •
edited
Loading

Maybe a rebase can fix the build. But the build fail

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 20, 2024
Base automatically changed from release/hycu to master November 20, 2024 18:25
@anooparveti anooparveti dismissed darsene’s stale review November 20, 2024 18:25

The base branch was changed.

@ThibaudCrespin ThibaudCrespin changed the base branch from master to develop November 21, 2024 08:26
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 21, 2024
darsene
darsene previously approved these changes Nov 21, 2024
View reviewed changes
feat(hycu): add click tracking
0663986 
ref: MANAGER-14800

Signed-off-by: Thibaud Crespin <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darsene darsene darsene approved these changes

@pauldkn pauldkn pauldkn approved these changes

@tibs245 tibs245 tibs245 approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThibaudCrespin @tibs245 @pauldkn @darsene