Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-ai-endpoints): create AI Endpoints react app #13928

Merged
merged 17 commits into from
Nov 25, 2024
Merged

feat(pci-ai-endpoints): create AI Endpoints react app #13928

merged 17 commits into from
Nov 25, 2024

Conversation

Masta2000
Copy link
Contributor

ref:AIS-859

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets AIS-859
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Create react-app for AI Endpoints

Related

@Masta2000 Masta2000 requested review from a team as code owners November 5, 2024 08:25
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Nov 5, 2024
abullet33
abullet33 previously approved these changes Nov 13, 2024
View reviewed changes
tristanwagner
tristanwagner requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@tristanwagner tristanwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix sonarcloud issues and more importantly this one

tristanwagner
tristanwagner previously approved these changes Nov 13, 2024
View reviewed changes
anooparveti
anooparveti requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the folders e2e, mocks and playwright.config.ts

packages/manager/apps/pci-ai-endpoints/public/translations/onboarding/Messages_fr_FR.json Outdated Show resolved Hide resolved
packages/manager/apps/pci-ai-endpoints/src/components/Error/Error.tsx Outdated Show resolved Hide resolved
@abullet33 abullet33 force-pushed the feat/ai-apps branch 2 times, most recently from 6a2c3dd to 6f79dc4 Compare November 14, 2024 09:18
@abullet33 abullet33 changed the base branch from master to develop November 14, 2024 09:18
darsene and others added 14 commits November 21, 2024 11:43
@darsene @abullet33
feat(pci-ai-endpoints): fix build
9b2db0d 
ref: AIS-859

Signed-off-by: David Arsène <[email protected]>
@abullet33
feat(pci-ai-endpoints): fix sonarQube erros
399395d 
ref:AIS-859
Signed-off-by: Chris Fradet <[email protected]>
@abullet33
feat(ai.endpoints): clean branch and rework onboarding
e02bb57 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): clean branch and use epic branch
8144a3e 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): remove useless file
2b783c9 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): rework onboarding page
0def538 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): fix build issue
8e3a4a4 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): fix pr comments
740a7b9 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): update guide link
526ee5d 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): update pci menu to display beta badge
a4b3d68 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): fix pr comments
4da30e4 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
feat(ai.endpoints): fix ca guide link issue
2f5057e 
Signed-off-by: Arthur Bullet <[email protected]>
@abullet33
fix(i18n): add missing translations [CDS 133]
1e68468 
Signed-off-by: CDS Translator Agent <[email protected]>
@abullet33
feat(ai.endpoints): resolve conflict
a38c1e0 
Signed-off-by: Arthur Bullet <[email protected]>
@github-actions github-actions bot added translation required and removed universe-public-cloud has conflicts Has conflicts to resolve before merging labels Nov 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@anooparveti anooparveti changed the base branch from develop to release/ai-endpoints November 25, 2024 14:39
@anooparveti anooparveti merged commit 128a31e into release/ai-endpoints Nov 25, 2024
13 of 16 checks passed
@anooparveti anooparveti deleted the feat/ai-apps branch November 25, 2024 14:41
anooparveti pushed a commit that referenced this pull request Nov 25, 2024
@Masta2000 @darsene
@abullet33 @ovh-cds @anooparveti
feat(pci-ai-endpoints): create AI Endpoints react app (#13928)
8f70ed9 
ref:AIS-859

Signed-off-by: Chris Fradet <[email protected]>
Co-authored-by: David Arsène <[email protected]>
Co-authored-by: Arthur Bullet <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
@anooparveti anooparveti mentioned this pull request Nov 26, 2024
Merged
1 task
anooparveti pushed a commit that referenced this pull request Nov 26, 2024
@Masta2000 @darsene
@abullet33 @ovh-cds @anooparveti
feat(pci-ai-endpoints): create AI Endpoints react app (#13928)
2695986 
ref:AIS-859

Signed-off-by: Chris Fradet <[email protected]>
Co-authored-by: David Arsène <[email protected]>
Co-authored-by: Arthur Bullet <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jperchoc jperchoc jperchoc approved these changes

@anooparveti anooparveti anooparveti approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

@tristanwagner tristanwagner Awaiting requested review from tristanwagner

@abullet33 abullet33 Awaiting requested review from abullet33

Assignees
No one assigned
Labels
container dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Masta2000 @tristanwagner @anooparveti @jperchoc @abullet33 @darsene