Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci.instances): use shell to navigate to public-ip #13948

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(pci.instances): use shell to navigate to public-ip #13948

wants to merge 1 commit into from
+81 −8

Conversation

y4nnL
Copy link
Contributor

@y4nnL y4nnL commented Nov 5, 2024

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-876
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

@y4nnL y4nnL requested review from a team as code owners November 5, 2024 16:21
SimonChaumet
SimonChaumet previously approved these changes Nov 5, 2024
View reviewed changes
@y4nnL y4nnL force-pushed the TAPC-876 branch 3 times, most recently from 9527ecd to bbff378 Compare November 21, 2024 08:52
fix(pci.instances): use shell to navigate to public-ip
ef23017 
ref: TAPC-876
Signed-off-by: Yann Lojewski <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@chipp972 chipp972 chipp972 approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ppprevost ppprevost Awaiting requested review from ppprevost

@SimonChaumet SimonChaumet Awaiting requested review from SimonChaumet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@y4nnL @SimonChaumet @ppprevost @chipp972 @fredericvilcot