Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pci kubernetes show etcd 3 tapc 23 #14143

Merged

Conversation

ppprevost
Copy link
Contributor

@ppprevost ppprevost commented Nov 18, 2024

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix TAPC-23
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Feature: Display ETCD quota usage for Kubernetes clusters.

Description:
Added an indicator for ETCD quota usage on the Kubernetes cluster dashboard.

Gauge behavior:

Blue: usage < 70%
Orange: usage between 70% and 79%
Red: usage ≥ 80%
Banner:
A warning banner is displayed when ETCD usage is ≥ 80%, with a message and link to documentation. The banner is removed when usage drops below 80%.

Field name: "ETCD Quota Usage" (displayed in MiB with tooltips).

Placement: The gauge is positioned at the bottom of the cluster information section.

Related

@ppprevost ppprevost requested review from a team as code owners November 18, 2024 10:38
@github-actions github-actions bot added translation required feature New feature has conflicts Has conflicts to resolve before merging labels Nov 18, 2024
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_show-etcd-3_tapc-23 branch from 0e742b8 to bfeea77 Compare November 18, 2024 13:53
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 18, 2024
SimonChaumet
SimonChaumet previously approved these changes Nov 19, 2024
fredericvilcot
fredericvilcot previously approved these changes Nov 19, 2024
Copy link
Contributor

@fredericvilcot fredericvilcot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@@ -627,3 +628,14 @@ export const useCreateKubernetesCluster = ({
...mutation,
};
};

export const useGetClusterEtcdUsage = (projectId, kubeId) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const useGetClusterEtcdUsage = (projectId, kubeId) => {
export const useClusterEtcdUsage = (projectId, kubeId) => {

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 20, 2024
ovh-ux-cds and others added 10 commits November 21, 2024 10:27
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
Pierre-Philippe added 4 commits November 21, 2024 10:28
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-23
Signed-off-by: Pierre-Philippe <[email protected]>
@ppprevost ppprevost force-pushed the feat/pci-kubernetes_show-etcd-3_tapc-23 branch from 334ea83 to 5def5b3 Compare November 21, 2024 09:39
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 21, 2024
Copy link

sonarcloud bot commented Nov 21, 2024

@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w48 November 22, 2024 07:08
@anooparveti anooparveti merged commit e52e404 into release/public-cloud-w48 Nov 22, 2024
13 of 17 checks passed
@anooparveti anooparveti deleted the feat/pci-kubernetes_show-etcd-3_tapc-23 branch November 22, 2024 07:10
anooparveti pushed a commit that referenced this pull request Nov 25, 2024
ref: TAPC-23

Signed-off-by: Pierre-Philippe <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
ppprevost added a commit that referenced this pull request Nov 27, 2024
ref: TAPC-23

Signed-off-by: Pierre-Philippe <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants