fix(kms): fix urn region on credential creation root account #14200
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anooparveti
previously approved these changes
Nov 21, 2024
rjamet-ovh
previously approved these changes
Nov 21, 2024
vovh
force-pushed
the
fix/MANAGER-16086
branch
from
81601bd
to
8dc873e
Compare
darsene
previously approved these changes
Nov 25, 2024
rjamet-ovh
previously approved these changes
Nov 25, 2024
rjamet-ovh
reviewed
Nov 25, 2024
| @@ -5,7 +5,7 @@ import { | |||
| IdentityType, | |||
| } from '@/types/identity.type'; | |||
|
|
|||
| const urnIdentityRegExp = /^urn:v(\d):(eu|ca|us|labeu):([a-z]+):([a-z]+):([a-z]{2}\d{1,6}-ovh)\/?(.+?)?$/; | |||
| const urnIdentityRegExp = /^urn:v(\d):(eu|ca|us|labeu):([a-z]+):([a-z]+):([a-z]{2}\d{1,6}-ovh)\/?(.+?)?$/i; | |||
There was a problem hiding this comment.
Maybe add some test cases for the uppercase use cases ?
ref: MANAGER-16086 Signed-off-by: Vincent BONMARCHAND <[email protected]>
vovh
force-pushed
the
fix/MANAGER-16086
branch
from
8dc873e
to
40a6215
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription
Related