Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): add test and common-api module #14212

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat(*): add test and common-api module #14212

merged 2 commits into from
Nov 21, 2024

Conversation

chipp972
Copy link
Contributor

ref: MANAGER-15700

Question Answer
Branch? feat/vcd-veeam-postga
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15700
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested review from a team as code owners November 21, 2024 09:30
@chipp972 chipp972 requested review from sidlynx, seven-amid, qpavy, oalkabouss and darsene and removed request for a team November 21, 2024 09:30
@github-actions github-actions bot added continuous-integration Changes to our CI configuration files and scripts universe-bare-metal-cloud dependencies Pull requests that update a dependency file common feature New feature labels Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@testing-library/jest-dom UPDATED 6.5.0 6.6.3

@chipp972 chipp972 force-pushed the feat/vcd-veeam-new-modules branch 2 times, most recently from 4054eea to 66fa41f Compare November 21, 2024 10:08
@chipp972 chipp972 force-pushed the feat/vcd-veeam-new-modules branch 5 times, most recently from fd54c4c to aa2eb9f Compare November 21, 2024 15:49
Nicolas Pierre-charles added 2 commits November 21, 2024 16:53
feat(*): add test-utils and common-api modules
bc331ff 
ref: MANAGER-15700

Signed-off-by: Nicolas Pierre-charles <[email protected]>
fix(*): fix master problems
26699dc 
ref: MANAGER-15700

Signed-off-by: Nicolas Pierre-charles <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
58.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@chipp972 chipp972 merged commit b6e5f06 into feat/vcd-veeam-postga Nov 21, 2024
11 of 13 checks passed
@chipp972 chipp972 deleted the feat/vcd-veeam-new-modules branch November 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldkn pauldkn pauldkn approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
common continuous-integration Changes to our CI configuration files and scripts dependencies Pull requests that update a dependency file feature New feature universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipp972 @pauldkn