Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-object-storage): routing and layout tabs #14250

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(pci-object-storage): routing and layout tabs #14250

merged 1 commit into from
Nov 25, 2024

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Nov 25, 2024

ref: DTCORE-2874

Question Answer
Branch? pci-object-storage
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-2874
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners November 25, 2024 13:50
@kqesar kqesar requested review from sidlynx, seven-amid, tibs245, oalkabouss and ghyenne and removed request for a team November 25, 2024 13:50
@kqesar
feat(pci-object-storage): routing and layout tabs
a4efcdf 
ref: DTCORE-2874
Signed-off-by: Yoann Fievez <[email protected]>
@kqesar kqesar merged commit ef9ea45 into feat/pci-object-storage Nov 25, 2024
10 of 11 checks passed
@kqesar kqesar deleted the feat/DTCORE-2874 branch November 25, 2024 14:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven-amid seven-amid seven-amid approved these changes

@frenautvh frenautvh frenautvh approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kqesar @frenautvh @seven-amid