feat(hycu): add link to manage contacts #14263
Conversation
ref: MANAGER-15782 Signed-off-by: Paul Dickerson <[email protected]>
pauldkn
requested review from
sidlynx,
kqesar,
antonymarion,
MaximeBajeux and
oalkabouss
github-actions
bot
added
universe-bare-metal-cloud
translation required
feature
|
| {isLoadingContactUrl ? ( | ||
| <OsdsSkeleton /> | ||
| ) : ( | ||
| <Links | ||
| href={(contactUrl as string) ?? '#'} | ||
| type={LinkType.next} | ||
| label={t('hycu_dashboard_field_label_manage_contacts')} | ||
| className="mt-4" | ||
| /> | ||
| )} |
There was a problem hiding this comment.
Just little suggestion with a question :
When I implemented this I use disabled because the content not change and the load is very fast (Is not a web request just a local async function)
So I find this more readable, more maintainable and have better UX / CLS
What do you think ?
But is good implementation too
| Array.from({ length: 3 }).map((_, index) => ( | ||
| <OsdsSkeleton key={index} /> | ||
| )) |
There was a problem hiding this comment.
| Array.from({ length: 3 }).map((_, index) => ( | |
| <OsdsSkeleton key={index} /> | |
| )) | |
| <> | |
| <OsdsSkeleton /> | |
| <OsdsSkeleton /> | |
| <OsdsSkeleton /> | |
| </> | |
| ) |
No need to re-calculate a list of static components on each render I think
There was a problem hiding this comment.
I think the loop is better to maintain the code and avoid repetition. Maybe another opinion to known what method to choose ?
ref: MANAGER-15782
masterDescription
Related