feat(*): init logs to customer module #14281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjamet-ovh
requested review from
sidlynx,
kqesar,
qpavy,
JacquesLarique and
mhelhali-soufien
and removed request for
a team
added 2 commits
November 26, 2024 15:51
ref: MANAGER-15966 Signed-off-by: Romain Jamet <[email protected]>
ref: MANAGER-15966 Signed-off-by: Romain Jamet <[email protected]>
rjamet-ovh
force-pushed
the
feat/MANAGER-15966
branch
from
c70352b
to
94d3acd
Compare
|
pauldkn
approved these changes
Nov 26, 2024
darsene
reviewed
Nov 26, 2024
| type={ODS_MESSAGE_TYPE.error} | ||
| > | ||
| <OsdsText color={ODS_THEME_COLOR_INTENT.error}> | ||
| <div>Une erreur est survenue</div> |
| }) | ||
| } | ||
| > | ||
| reload logs |
| </div> | ||
| ); | ||
|
|
||
| if (logKinds.length === 0) return <div>no logkinds</div>; |
Comment on lines
+32
to
+35
| const newLogKind = logKinds.find( | ||
| (k) => k.kindId === event.detail.value, | ||
| ); | ||
| setCurrentLogKind(newLogKind); |
There was a problem hiding this comment.
So if newLogKind is undefined (not found), is it OK to reset the currentLogKind ?
| "declaration": true, | ||
| "resolveJsonModule": true, | ||
| "allowJs": true, | ||
| "jsx": "react" |
There was a problem hiding this comment.
To add @/... in all your imports
Suggested change
| "jsx": "react" | |
| "jsx": "react", | |
| "paths": { | |
| "@/*": ["./src/*"] | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/logs-to-customer-moduleBreaking change is mentioned in relevant commitsDescription