Multiple reminders - Email & Popup #410

ElieSauveterre · 2014-04-17T14:44:18Z

I made a fork from Iridias work (https://github.com/Iridias/calendar) and added/modified the code to implement the following features :

Multiple reminder/alarm by event
Combobox to choose between email or popup
Background job to send email reminders
Display popup reminder if you have your browser open on the calendar

read alarm-related data from calender-event and assign it to the template as well

…larm-times are now generated in a loop

georgehrke · 2014-04-17T14:54:27Z

cool, I'll review asap.

btw, why did you reformat all the code? the code style you use (e.g. spaces instead of tabs) doesn't comply with our coding guidelines

ElieSauveterre · 2014-04-17T15:01:59Z

Sorry for the formatting, my IDE do that when I save a file. Is there somewhere I can find those guidelines ?
I found this link (http://owncloud.org/contribute/), but it's not very clear about code formatting.

ElieSauveterre · 2014-05-04T22:50:53Z

Ok, but how does that work ?
If my pull request is accepted, I will find my new text on Transifex and then I will have to add the translation directly on Transifex ?

This fixes click handlers on the document

Possible Fix for owncloud/calendar#463 Please use the label only for the checkbox and not for the whole line, it runs into problems with the sharing dialog box!

georgehrke · 2014-08-07T13:10:14Z

@ElieSauveterre please revert all your code reformats and squash the commits

Combobox to choose between email or popup Background job to send email reminders Display popup reminder if you have your browser open on the calendar

ElieSauveterre · 2014-08-08T00:30:05Z

@georgehrke That should be better now.

The UI permits downloading a calendar shared with you, but the response was Forbidden 403 becuase export.php wasn't setting the shared parameter to true in it's calls to fetch the resource.

Conflicts: css/style.css js/calendar.js js/on-event.js l10n/de.php l10n/de_AT.php l10n/de_CH.php l10n/de_DE.php l10n/en_GB.php l10n/fr.php lib/object.php

Overwrite getMultipleChildren to create calendar objects of OC_Connector_Sabre_CalDAV_CalendarObject which return the correct ACL for shared calendars.

thigg · 2015-08-17T10:31:18Z

Is this still in active development? Its one of my most needed features.

ElieSauveterre · 2015-08-20T14:59:12Z

@thigg Not very active. When I upgrade Owncloud on my server, I also update the plugin to make it work.

Use new Sabre object

Kwaadpepper · 2015-10-15T14:57:48Z

Just a suggestion to this if it still in development which i hope, my phone provider allows me to send sms with a webhook http and a query arg for message. eg:
https://phoneprovider/?auth=blah&message=myreminder message

This would be helpful

ElieSauveterre · 2015-10-15T16:21:23Z

@Kwaadpepper Great idea. If you want to implement it, you are welcome. These days I don't have the time to work on that.

Kwaadpepper · 2015-10-16T15:10:47Z

@ElieSauveterre i'm working slowly on this. I just have a question, is the email event actually working ? I tried to make this work but it just seems that it does not trigger.
I have test the mail function is working using OC 8.1.3 stable. I also saw that OCP\Backgroundjob::registerJob is deprecated. Anyway i need to update the background job to make a curl call but i would like to test the mail function first.

Could you confirm this is still working for the release i mentioned ?

ElieSauveterre · 2015-10-16T20:15:02Z

@Kwaadpepper Indeed, the email reminder does not work, I think it's since the last merge I made. Something must have changed regarding how background jobs are working.

ElieSauveterre · 2015-10-16T23:38:26Z

@Kwaadpepper Emails reminder should work know. I tested on Owncloud 8.1.1 (stable)

Kwaadpepper · 2015-10-17T11:22:51Z

@ElieSauveterre Ok thanks 👍
I also confirm this is working on OC 8.1.3 stable

Kwaadpepper · 2015-10-17T11:57:11Z

@ElieSauveterre i just saw that the email format is incorrect, it send html in plain with no boundaries for html actually. I'll look into that as i add webhook feature, also i had to workaround INTERVAL, BETWEEN and UTC_TIMESTAMP() as i use sqlite and it does not support these, i used php functions (gmdate, strtotime) so it works.

ElieSauveterre · 2015-10-17T14:43:00Z

@Kwaadpepper I used the function "setPlainBody" for the email body. Maybe it will be better to use "setHtmlBody" and add html tags to the content.

3rdparty/curl.php add new handy class to make curl calls README.md add optionfield appinfo/database.xml add optionfield with length at 1024 since max url is 2000 should be ok ajax/event/new.php add $_POST['alarmsOptionField'] to OC_Calendar_Object::addAlarmsDB call ajax/event/edit.php add $_POST['alarmsOptionField'] to OC_Calendar_Object::addAlarmsDB call ajax/event/new.form.php add default for all Alarm Types in initialize default optionfield js/on-event.js add .alarmType (select) change event js/settings.js add saving methods for default alarm types and default webhook url js/calendar.js add switchAlarmType to show hide optionfield input depending on alarm type removes the hidden default alarm since it is send and saved on the DB instead base alarm html is written in Calendar.UI.ALARMBASETPL by the template and used in addAlarm templates/calendar.php add alarm configuration html templates/part.eventform.php add default alarm template (sotes it in Calendar.UI.ALARMBASETPL) add Webhook Option initialize default optionfield lib/alarm.php made PS2 compliant with phpcs since it make a lot of changes add function dispatch to call apropriate function for a given alarm type also replaces some sql functions with native php since sqlite does these add sendWebhooksAlarm exec WEBHOOK alarms with the new curl class and therefore replaces $message in option field with urlencoded text template (same as email plain text) this function uses regex to achieve replacement and url parsing add sendEmailsAlarm exec EMAIL alarms and send them in html and plain text (added html boundarie) add setAlarmSent makes the alarm as sent in database (refactored) add genMessage to generate a template (html, text) (refactored) lib/object.php add optionfield in SELECT and INSERT to needed sql queries replace some SQL function (DATE_SUB, UTC_TIMESTAMP, INTERVAL) with native php since sqlite does not support these bind AUDIO to WEBHOOK and vice versa to provide a method to set webhook using CALDAV see http://www.ietf.org/rfc/rfc4791.txt 8.6. Storing and Using Alarms add ajax/settings/setdefaultalarms.php add ajax/settings/setwebhookdefaulturl.php add templates/event.alarm.text.php appinfo/routes.php add routes setdefaultalarms and setwebhookdefaulturls css/style.css add .webhookUrlEvent and .alarmOptionField style rules

Webhook alarms, Bug fixing and default alarm options

Kwaadpepper · 2015-10-18T14:14:27Z

I just noticed a small issue, i use Kontact from plasma5 (Kubuntu/linux).
It let me set AUDIO and script which i believe is PROCEDURE in the CALDAV rfc.

Reminders coming from OC are correct except webhook which is shown as TEXT, that i because it may be sent as invalid from OC (i believe i changed it to AUDIO, but i guess i should have change it to PROCEDURE).

Also reminders set from Kontact are not parsed in OC whereas it should.

Any ideas on this ?

ElieSauveterre · 2015-10-18T14:31:51Z

The Sabre library is not very simple to use.
Kontact probably as a different format for the reminder. When I added reminders to the calendar I used Thunderbird as example.

lib/object.php Fix CALDAV issue from previous commit Now properly bind PROCEDURE to WebHOOK muhahahaha !!!!

Kwaadpepper · 2015-10-18T15:01:01Z

@ElieSauveterre I just broke something in the last commit.
The new PR solves this and properly bind PROCEDURE to WEBHOOK !

Also i wish i could use Thunderbird, but the moz devs are not likely willing to support other ALARM methods from the CALDAV RFC.
Kontact fully support these and is working, with it i can trigger webhook event on OC with my laptop 💃

Fix CALDAV issue

bohni · 2015-11-19T16:24:48Z

@ElieSauveterre @georgehrke Now that owncloud 8.2.x is out, the original calendar app still does not support reminders.

Will this fork be merged to the official branch in (near) future? Or will the official calendar never support reminders?

tualatin · 2015-12-02T07:44:05Z

I thought, that a former version of owncloud supports notification in the calendar app, but it seems that I'm wrong. Will this feature included in the official calendar app in the near future? It will be very great!

Iridias added 4 commits March 20, 2014 13:53

read alarm-related data from calender-event

19f3df3

read alarm-related data from calender-event and assign it to the template as well

show alarm times in event form and support editing it

c6c7834

added german and english translation for simple alarm feature

b0743f6

allow setting valarm-actiontype via request / selectbox-entries for a…

ce03dbe

…larm-times are now generated in a loop

vgezer added the Enhancement label May 4, 2014

Iridias mentioned this pull request May 23, 2014

Simple feature to configure alarm/reminders for an event #376

Closed

georgehrke and others added 8 commits July 4, 2014 12:52

better validation for accessclass, fixes #423

602abb4

add ocsid

dac0113

Fixed weird event registration

4390e12

This fixes click handlers on the document

Possible Fix #463

49e8185

Possible Fix for owncloud/calendar#463 Please use the label only for the checkbox and not for the whole line, it runs into problems with the sharing dialog box!

backport 483

1445d6c

Fix import.

f91e27b

don't change active state when updating calendar

023367f

Allow only owner of calendar edit shared calendars - pr 385

b434d26

georgehrke added the 5 - To review label Aug 7, 2014

show 'Clear cache for repeating events' only when debug is enabled

eea7982

Multiple reminder/alarm by event

d1f1530

Combobox to choose between email or popup Background job to send email reminders Display popup reminder if you have your browser open on the calendar

georgehrke and others added 7 commits August 8, 2014 21:01

fix issue with repeating events in week 52

042673e

Allow download of shared calendars and events

4d606bd

The UI permits downloading a calendar shared with you, but the response was Forbidden 403 becuase export.php wasn't setting the shared parameter to true in it's calls to fetch the resource.

fix caldav issue that could lead to etag problems

c9e23e8

add reply-to field to e-mail when using "send mail"

5d7e754

reply-to is not possible with core's sendMail, therefore remove reply-to

337d2ed

Send Mail: User proper displayname instead of string "user"

80b3fdf

Merge branch 'Main-source/stable7'

5b77342

Conflicts: css/style.css js/calendar.js js/on-event.js l10n/de.php l10n/de_AT.php l10n/de_CH.php l10n/de_DE.php l10n/en_GB.php l10n/fr.php lib/object.php

georgehrke force-pushed the master branch from b5aefcc to a723bf9 Compare September 2, 2014 13:04

Raimund Schlüßler and others added 3 commits August 12, 2015 20:30

Fix appname string

6d68a0c

Overwrite getMultipleChildren

097baf4

Overwrite getMultipleChildren to create calendar objects of OC_Connector_Sabre_CalDAV_CalendarObject which return the correct ACL for shared calendars.

increment version number

d756b5b

ElieSauveterre added 5 commits August 26, 2015 09:29

Merge remote-tracking branch 'upstream/stable8.1'

7fbe126

Fix merge

bb6c62c

Use new Sabre object

Fix merge

9371375

Use new Sabre object

Fix creation VALARM

e8cc6ff

Fix creation VALARM

3b39c65

DeepDiver1975 added this to the backlog milestone Oct 13, 2015

Fix background job that send email reminder

1271f1d

Kwaadpepper and others added 3 commits October 18, 2015 05:39

Merge pull request #2 from Kwaadpepper/master

81eae7c

Webhook alarms, Bug fixing and default alarm options

Fix email alarm sent

271a1c7

Fix CALDAV issue

48b59fc

lib/object.php Fix CALDAV issue from previous commit Now properly bind PROCEDURE to WebHOOK muhahahaha !!!!

Merge pull request #3 from Kwaadpepper/master

07d2f7c

Fix CALDAV issue

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple reminders - Email & Popup #410

Multiple reminders - Email & Popup #410

ElieSauveterre commented Apr 17, 2014

georgehrke commented Apr 17, 2014

ElieSauveterre commented Apr 17, 2014

ElieSauveterre commented May 4, 2014

georgehrke commented Aug 7, 2014

ElieSauveterre commented Aug 8, 2014

thigg commented Aug 17, 2015

ElieSauveterre commented Aug 20, 2015

Kwaadpepper commented Oct 15, 2015

ElieSauveterre commented Oct 15, 2015

Kwaadpepper commented Oct 16, 2015

ElieSauveterre commented Oct 16, 2015

ElieSauveterre commented Oct 16, 2015

Kwaadpepper commented Oct 17, 2015

Kwaadpepper commented Oct 17, 2015

ElieSauveterre commented Oct 17, 2015

Kwaadpepper commented Oct 18, 2015

ElieSauveterre commented Oct 18, 2015

Kwaadpepper commented Oct 18, 2015

bohni commented Nov 19, 2015

tualatin commented Dec 2, 2015

Multiple reminders - Email & Popup #410

Are you sure you want to change the base?

Multiple reminders - Email & Popup #410

Conversation

ElieSauveterre commented Apr 17, 2014

georgehrke commented Apr 17, 2014

ElieSauveterre commented Apr 17, 2014

ElieSauveterre commented May 4, 2014

georgehrke commented Aug 7, 2014

ElieSauveterre commented Aug 8, 2014

thigg commented Aug 17, 2015

ElieSauveterre commented Aug 20, 2015

Kwaadpepper commented Oct 15, 2015

ElieSauveterre commented Oct 15, 2015

Kwaadpepper commented Oct 16, 2015

ElieSauveterre commented Oct 16, 2015

ElieSauveterre commented Oct 16, 2015

Kwaadpepper commented Oct 17, 2015

Kwaadpepper commented Oct 17, 2015

ElieSauveterre commented Oct 17, 2015

Kwaadpepper commented Oct 18, 2015

ElieSauveterre commented Oct 18, 2015

Kwaadpepper commented Oct 18, 2015

bohni commented Nov 19, 2015

tualatin commented Dec 2, 2015